declare timeout ini options as float - #200
Open
zxyasfas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #194.
With pytest 9's native
[tool.pytest]table,timeout = 1200(a TOML int) makes the whole session die at configure time:because
timeoutandsession_timeoutare registered with the default string ini type. Registering them withtype="float"fixes it, matching what the values actually are. Legacy[pytest]ini strings liketimeout = 2.5still parse the same way, andtimeout = 0still means disabled (the> 0checks are unchanged).One catch:
type="float"was added toaddiniin pytest 8.4, and registering it under 8.0.x fails at plugin load, so this bumps the floor in setup.cfg topytest>=8.4.0. If keeping 8.0 support matters more, the alternative is a try/except shim around the registration; happy to switch if you prefer that.Added a regression test using
makepyprojecttomlwith int values for both options (skipped below pytest 9, where the native table doesn't exist). Suite passes locally on 3.12: 35 passed, 21 skipped (the pexpect spawn skips, this is a Windows machine).