gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ by perrinjerome · Pull Request #113359 · python/cpython

perrinjerome · 2023-12-21T14:09:03Z

Issue: Exception with broken __getattr__ causes error rendering tracebacks #113358

ghost · 2023-12-21T14:09:07Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2023-12-21T14:09:08Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

iritkatriel · 2023-12-21T16:17:38Z

+        try:
+            notes = getattr(exc_value, '__notes__', None)
+        except Exception:
+            pass


We don't swallow exceptions like this. What is your use case for defining an exception with a broken __getattr__?

I had much the same question on the issue. Python reporting bugs in user code does not seem like a python bug. OP needs to justify the python bug claim by quoting doc that says that user exceptions will by caught, or make this a feature request, with justification.

Thank you for your feedback, I am sorry I did not explain enough. I have tried to add more context to the issue.

About not swallowing exceptions, I don't like it either (and I understand the negative feedback), maybe this patch should be adjusted to at least report that an exception occurred while getting the notes, by doing something like this instead ?

try: self.__notes__ = getattr(exc_value, '__notes__', None) except Exception as e: self.__notes__ = [ f'Ignored exception getting __notes__: {_safe_string(e, '__notes__', repr)}']

Unfortunately we do swallow exceptions like this. _safe_string() set a bad precedence since 2823f03.

I have updated the patch to include the "Ignored exception getting notes ..." in the notes as suggested above, from the discussion on the issue it seemed better to include information about the error in that case.

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

miss-islington-app · 2024-01-16T10:06:26Z

Thanks @perrinjerome for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app · 2024-01-16T10:06:26Z

Thanks @perrinjerome for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

…en __getattr__ (pythonGH-113359) (cherry picked from commit 04fabe2) Co-authored-by: Jérome Perrin <perrinjerome@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

miss-islington-app · 2024-01-16T10:06:35Z

Sorry, @perrinjerome and @vsajip, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 04fabe22dd98b4d87f672254b743fbadd5206352 3.11

bedevere-app · 2024-01-16T10:06:36Z

GH-114105 is a backport of this pull request to the 3.12 branch.

… a broken __getattr__ (pythonGH-113359) (cherry picked from commit 04fabe2) Co-authored-by: Jérome Perrin <perrinjerome@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

bedevere-app · 2024-01-16T10:30:22Z

GH-114109 is a backport of this pull request to the 3.11 branch.

… a broken __getattr__ (pythonGH-113359) (cherry picked from commit 04fabe2) Co-authored-by: Jérome Perrin <perrinjerome@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

bedevere-app · 2024-01-16T14:14:03Z

GH-114118 is a backport of this pull request to the 3.11 branch.

bedevere-app · 2024-01-16T14:17:53Z

GH-114118 is a backport of this pull request to the 3.11 branch.

bedevere-app · 2024-01-16T14:18:35Z

GH-114118 is a backport of this pull request to the 3.11 branch.

…en __getattr__ (pythonGH-113359) cherry picked from commit 04fabe2 Adjusted for 3.11, because exception printing also happens in C code. For simplicity, instead of including the repr of the exception that happened during __getattr__, this just prints that an error occured. Co-authored-by: Jérome Perrin <perrinjerome@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

…en __getattr__ (pythonGH-113359) cherry picked from commit 04fabe2 Adjusted for 3.11, because exception printing also happens in C code. Co-authored-by: Jérome Perrin <perrinjerome@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

bedevere-app · 2024-01-17T06:55:11Z

GH-114173 is a backport of this pull request to the 3.12 branch.

…en __getattr__ (pythonGH-113359) cherry picked from commit 04fabe2 Adjusted for 3.12, because exception printing also happens in C code. Co-authored-by: Jérome Perrin <perrinjerome@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

…ken __getattr__ (GH-113359) (#114118)

… a broken __getattr__ (pythonGH-113359) (cherry picked from commit 04fabe2) Co-authored-by: Jérome Perrin <perrinjerome@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

…ken __getattr__ (GH-113359) (#114173)

…en __getattr__ (pythonGH-113359) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

Fix rendering tracebacks with exceptions with a broken __getattr__

1f40d5f

bedevere-app Bot mentioned this pull request Dec 21, 2023

Exception with broken __getattr__ causes error rendering tracebacks #113358

Closed

📜🤖 Added by blurb_it.

9eed42e

perrinjerome marked this pull request as ready for review December 21, 2023 15:31

perrinjerome requested a review from iritkatriel as a code owner December 21, 2023 15:31

bedevere-app Bot added the awaiting review label Dec 21, 2023

iritkatriel reviewed Dec 21, 2023

View reviewed changes

terryjreedy requested a review from vsajip December 22, 2023 14:28

perrinjerome added 2 commits January 15, 2024 14:36

Display error accessing __notes__ along with the traceback

8651d3e

fixup! Display error accessing __notes__ along with the traceback

6ecf82d

vsajip approved these changes Jan 15, 2024

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 15, 2024

iritkatriel reviewed Jan 15, 2024

View reviewed changes

Comment thread Lib/traceback.py Outdated

perrinjerome commented Jan 15, 2024

View reviewed changes

Comment thread Lib/test/test_traceback.py Outdated

Apply suggestions from code review

6c6867a

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

vsajip merged commit 04fabe2 into python:main Jan 16, 2024

bedevere-app Bot removed the awaiting merge label Jan 16, 2024

vsajip added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 16, 2024

miss-islington-app Bot assigned vsajip Jan 16, 2024

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 16, 2024

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 16, 2024

perrinjerome mentioned this pull request Jan 16, 2024

[3.11] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) #114118

Merged

iritkatriel pushed a commit that referenced this pull request Jan 19, 2024

[3.11] gh-113358: Fix rendering tracebacks with exceptions with a bro…

20f7cf2

…ken __getattr__ (GH-113359) (#114118)

iritkatriel pushed a commit that referenced this pull request Jan 21, 2024

[3.12] gh-113358: Fix rendering tracebacks with exceptions with a bro…

00e8c9c

…ken __getattr__ (GH-113359) (#114173)

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024

pythongh-113358: Fix rendering tracebacks with exceptions with a brok…

d7e7d74

…en __getattr__ (pythonGH-113359) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024

pythongh-113358: Fix rendering tracebacks with exceptions with a brok…

cb1bc3f

…en __getattr__ (pythonGH-113359) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

pythongh-113358: Fix rendering tracebacks with exceptions with a brok…

b4b5c9e

…en __getattr__ (pythonGH-113359) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

Uh oh!

Uh oh!

Conversation

perrinjerome commented Dec 21, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 21, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app Bot commented Dec 21, 2023

Uh oh!

iritkatriel Dec 21, 2023

Choose a reason for hiding this comment

Uh oh!

terryjreedy Dec 21, 2023

Choose a reason for hiding this comment

Uh oh!

perrinjerome Dec 22, 2023

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Dec 22, 2023

Choose a reason for hiding this comment

Uh oh!

perrinjerome Jan 15, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Jan 16, 2024

Uh oh!

miss-islington-app Bot commented Jan 16, 2024

Uh oh!

miss-islington-app Bot commented Jan 16, 2024

Uh oh!

bedevere-app Bot commented Jan 16, 2024

Uh oh!

bedevere-app Bot commented Jan 16, 2024

Uh oh!

bedevere-app Bot commented Jan 16, 2024

Uh oh!

bedevere-app Bot commented Jan 16, 2024

Uh oh!

bedevere-app Bot commented Jan 16, 2024

Uh oh!

bedevere-app Bot commented Jan 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

perrinjerome commented Dec 21, 2023 •

edited by bedevere-app Bot

Loading

ghost commented Dec 21, 2023 •

edited by ghost

Loading