Skip to content

gh-111968: Explicit handling for finalized freelist#113929

Merged
corona10 merged 6 commits into
python:mainfrom
corona10:gh-111968-list-fini
Jan 12, 2024
Merged

gh-111968: Explicit handling for finalized freelist#113929
corona10 merged 6 commits into
python:mainfrom
corona10:gh-111968-list-fini

Conversation

@corona10

@corona10 corona10 commented Jan 10, 2024

Copy link
Copy Markdown
Member

@corona10

corona10 commented Jan 10, 2024

Copy link
Copy Markdown
Member Author

Since we marked as finalized status at runtime, it should be checked.
see: #113886 (comment) and #113921 (comment)

@corona10 corona10 changed the title gh-111968: Explicit handling for finzliaed freelist of list gh-111968: Explicit handling for finzliazed freelist Jan 10, 2024
@corona10 corona10 changed the title gh-111968: Explicit handling for finzliazed freelist gh-111968: Explicit handling for finalized freelist Jan 10, 2024

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check in PyFloat_FromDouble does not seem necessary, but it's up to you.

Comment thread Objects/floatobject.c Outdated
@corona10
corona10 enabled auto-merge (squash) January 12, 2024 00:04
@corona10
corona10 merged commit efa738e into python:main Jan 12, 2024
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10
corona10 deleted the gh-111968-list-fini branch February 15, 2024 01:41
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants