Skip to content

gh-114275: Skip doctests that use asyncio in test_pdb for WASI builds#114309

Merged
vstinner merged 2 commits into
python:mainfrom
sobolevn:issue-114275-2
Jan 19, 2024
Merged

gh-114275: Skip doctests that use asyncio in test_pdb for WASI builds#114309
vstinner merged 2 commits into
python:mainfrom
sobolevn:issue-114275-2

Conversation

@sobolevn

@sobolevn sobolevn commented Jan 19, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Jan 19, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 19, 2024
Closed
@sobolevn

sobolevn commented Jan 19, 2024

Copy link
Copy Markdown
Member Author

!buildbot wasi*

@bedevere-bot

bedevere-bot commented Jan 19, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit d62a5e3 🤖

The command will test the builders whose names match following regular expression: wasi*

The builders matched are:

  • wasm32-wasi PR
  • wasm32 WASI 8Core PR

vstinner
vstinner reviewed Jan 19, 2024
View reviewed changes
Comment thread Lib/test/test_pdb.py Outdated
... loop.close()
... asyncio.set_event_loop_policy(None)
... print("finished")
if support.has_socket_support:

@vstinner vstinner Jan 19, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add a constant with a comment to explain the skip in a comment. Example:

# gh-114275: WASI fails to run asyncio tests, similar skip than test_asyncio.
SKIP_ASYNCIO_TESTS = (not support.has_socket_support)

(...)

if not SKIP_ASYNCIO_TESTS: (...)

vstinner
vstinner approved these changes Jan 19, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner

vstinner commented Jan 19, 2024

Copy link
Copy Markdown
Member

!buildbot WASI

@bedevere-bot

bedevere-bot commented Jan 19, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 142e3bc 🤖

The command will test the builders whose names match following regular expression: WASI

The builders matched are:

  • wasm32-wasi PR
  • wasm32 WASI 8Core PR

@vstinner

vstinner commented Jan 19, 2024

Copy link
Copy Markdown
Member

I prefer to be extra safe and check again the updated PR on WASI buildbots.

@vstinner
vstinner merged commit efb81a6 into python:main Jan 19, 2024
@vstinner

vstinner commented Jan 19, 2024

Copy link
Copy Markdown
Member

Tests passed on the two WASI buildbot workers. I merged your fix, thanks.

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@sobolevn @kulikjak
pythongh-114275: Skip doctests that use asyncio in test_pdb for W…
83b8813 
…ASI builds (python#114309)
@brettcannon brettcannon added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 22, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 22, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jan 22, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2024
@sobolevn @miss-islington
pythongh-114275: Skip doctests that use asyncio in test_pdb for W…
b53ae3a 
…ASI builds (pythonGH-114309)

(cherry picked from commit efb81a6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2024
@sobolevn @miss-islington
pythongh-114275: Skip doctests that use asyncio in test_pdb for W…
f507a15 
…ASI builds (pythonGH-114309)

(cherry picked from commit efb81a6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app

bedevere-app Bot commented Jan 22, 2024

Copy link
Copy Markdown

GH-114438 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 22, 2024
@bedevere-app

bedevere-app Bot commented Jan 22, 2024

Copy link
Copy Markdown

GH-114439 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 22, 2024
vstinner pushed a commit that referenced this pull request Jan 22, 2024
@miss-islington @sobolevn
[3.11] gh-114275: Skip doctests that use asyncio in test_pdb for …
5b12f7d 
…WASI builds (GH-114309) (#114438)

gh-114275: Skip doctests that use `asyncio` in `test_pdb` for WASI builds (GH-114309)
(cherry picked from commit efb81a6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit that referenced this pull request Jan 22, 2024
@miss-islington @sobolevn
[3.12] gh-114275: Skip doctests that use asyncio in test_pdb for …
4890ac1 
…WASI builds (GH-114309) (#114439)

gh-114275: Skip doctests that use `asyncio` in `test_pdb` for WASI builds (GH-114309)
(cherry picked from commit efb81a6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-114275: Skip doctests that use asyncio in test_pdb for W…
b6b5fd9 
…ASI builds (python#114309)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-114275: Skip doctests that use asyncio in test_pdb for W…
789de85 
…ASI builds (python#114309)
@Eclips4 Eclips4 mentioned this pull request Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @bedevere-bot @vstinner @brettcannon