Skip to content

gh-115687: Split up guards from COMPARE_OP#115688

Merged
Fidget-Spinner merged 5 commits into
python:mainfrom
Fidget-Spinner:split_compare_op
Feb 20, 2024
Merged

gh-115687: Split up guards from COMPARE_OP#115688
Fidget-Spinner merged 5 commits into
python:mainfrom
Fidget-Spinner:split_compare_op

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Feb 19, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Feb 19, 2024
Closed
2 tasks
markshannon
markshannon approved these changes Feb 20, 2024
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice incremental improvement.

@Fidget-Spinner
Fidget-Spinner enabled auto-merge (squash) February 20, 2024 10:08
@Fidget-Spinner
Fidget-Spinner enabled auto-merge (squash) February 20, 2024 10:15
@Fidget-Spinner
Fidget-Spinner merged commit dcba21f into python:main Feb 20, 2024
@Fidget-Spinner
Fidget-Spinner deleted the split_compare_op branch February 20, 2024 11:34
This was referenced Feb 20, 2024
Merged
Merged
@encukou

encukou commented Feb 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The refleaks buildbot failed on test.test_capi.test_opt.TestUops.test_confidence_score. Likely causes: GH-114142, GH-115558, or GH-115688
I'll investigate later if it's not fixed; you probably have more context.

Edit: it's likely to be fixed in #115728

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@Fidget-Spinner @woodruffw
pythongh-115687: Split up guards from COMPARE_OP (pythonGH-115688)
07ca325
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@Fidget-Spinner @diegorusso
pythongh-115687: Split up guards from COMPARE_OP (pythonGH-115688)
eebef01
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@Fidget-Spinner @LukasWoodtli
pythongh-115687: Split up guards from COMPARE_OP (pythonGH-115688)
e0d71a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fidget-Spinner @encukou @markshannon