Skip to content

Revert "gh-110119: Temporarily skip test_cppext on --disable-gil builds. (#110123)"#116964

Closed
colesbury wants to merge 1 commit into
python:mainfrom
colesbury:gh-110119-test_cppext
Closed

Revert "gh-110119: Temporarily skip test_cppext on --disable-gil builds. (#110123)"#116964
colesbury wants to merge 1 commit into
python:mainfrom
colesbury:gh-110119-test_cppext

Conversation

@colesbury

@colesbury colesbury commented Mar 18, 2024

Copy link
Copy Markdown
Contributor

The test_cppext can run now that the wheel package is updated.

This reverts commit 2973970.

…l builds. (python#110123)"

The `test_cppext` can run now that the `wheel` package is updated.

This reverts commit 2973970.
@colesbury

Copy link
Copy Markdown
Contributor Author

!buildbot nogil

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit a74c8da 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • AMD64 Ubuntu NoGIL PR
  • x86-64 MacOS Intel NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 MacOS M1 NoGIL PR

@colesbury

Copy link
Copy Markdown
Contributor Author

See also #116877, which updated wheel to 0.43.0

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corona10

Copy link
Copy Markdown
Member

#116973 conflicted PR?

@colesbury colesbury closed this Mar 19, 2024
@colesbury
colesbury deleted the gh-110119-test_cppext branch March 19, 2024 05:58
@colesbury

Copy link
Copy Markdown
Contributor Author

Yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants