gh-76785: Handle Legacy Interpreters Properly#117490
Merged
ericsnowcurrently merged 19 commits intoApr 11, 2024
Merged
Conversation
ericsnowcurrently
force-pushed
the
hide-legacy-subinterpreters
branch
4 times, most recently
from
April 9, 2024 20:53
1e32031 to
dcf6e8c
Compare
ericsnowcurrently
force-pushed
the
hide-legacy-subinterpreters
branch
from
April 10, 2024 23:39
dcf6e8c to
7de833a
Compare
ericsnowcurrently
force-pushed
the
hide-legacy-subinterpreters
branch
from
April 11, 2024 00:40
7de833a to
e38f141
Compare
ericsnowcurrently
marked this pull request as ready for review
April 11, 2024 20:40
ericsnowcurrently
enabled auto-merge (squash)
April 11, 2024 22:59
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
This is similar to the situation with threading._DummyThread. The methods (incl. __del__()) of interpreters.Interpreter objects must be careful with interpreters not created by interpreters.create(). The simplest thing to start with is to disable any method that modifies or runs in the interpreter. As part of this, the runtime keeps track of where an interpreter was created. We also handle interpreter "refcounts" properly.
This was referenced Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to the situation with
threading._DummyThread. The methods (incl.__del__()) ofinterpreters.Interpreterobjects must be careful with interpreters not created byinterpreters.create(). The simplest thing is to disable any method that modifies or runs in the interpreter. As part of this, the runtime keeps track of where an interpreter was created. We also handle interpreter "refcounts" properly.