gh-123987: Fix NotADirectoryError in NamespaceReader when sentinel present#124018
Merged
Conversation
jaraco
marked this pull request as draft
September 12, 2024 18:33
jaraco
force-pushed
the
gh-123987/sentinel-in-namespace-path
branch
from
September 12, 2024 18:35
aaab6d2 to
241d9e9
Compare
jaraco
changed the title
1 task
jaraco
force-pushed
the
gh-123987/sentinel-in-namespace-path
branch
from
September 12, 2024 19:38
241d9e9 to
1c6608a
Compare
jaraco
marked this pull request as ready for review
September 12, 2024 19:40
jaraco
enabled auto-merge (squash)
January 5, 2025 21:57
Member
|
ping @jaraco This has been open for a while. |
Member
Author
I've been trying not to merge code without review. I marked this one for auto-merge after review, but no one's reviewed it. Is there a reason you chose to ping me rather than review it? (not complaining, just curious) I'll get it updated and merged. |
jaraco
disabled auto-merge
January 26, 2025 16:06
jaraco
enabled auto-merge (squash)
January 26, 2025 16:07
|
Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 26, 2025
…nel present (pythonGH-124018) (cherry picked from commit b543b32) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
|
GH-129319 is a backport of this pull request to the 3.13 branch. |
Member
Author
|
Oh, interesting! This is the first time I've seen the auto-merge work without a second person to review (and manual merge wasn't possible). Great to see some streamlining of workflows. |
jaraco
added a commit
that referenced
this pull request
Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs with importlib_resources 6.4.5