gh-71339: Use new assertion methods in test_import and test_importlib#129052
Merged
serhiy-storchaka merged 1 commit intoJan 21, 2025
Merged
Conversation
serhiy-storchaka
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
jaraco,
ncoghlan and
warsaw
as code owners
January 20, 2025 10:38
brettcannon
approved these changes
Jan 20, 2025
ncoghlan
approved these changes
Jan 21, 2025
ncoghlan
left a comment
ncoghlan
left a comment
Contributor
There was a problem hiding this comment.
Looks like a straightforward test improvement to me.
Contributor
|
I was going to suggest backporting, but these methods are new in 3.14, so that's not an option. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jan 21, 2025
…est_importlib (pythonGH-129052) (cherry picked from commit f7cc7d2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-129123 is a backport of this pull request to the 3.13 branch. |
Member
Author
It is an option. See #129123. |
ambv
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They provide better error report.