gh-131895: fix $PATH for clang on Darwin runners for tail-calling interpreter#131903
Merged
picnixz merged 4 commits intoMar 30, 2025
Merged
Conversation
picnixz
requested review from
AA-Turner,
ezio-melotti and
hugovk
as code owners
March 30, 2025 12:23
picnixz
force-pushed
the
infra/fix/tail-calling-interpreter-darwin-clang-131895
branch
from
March 30, 2025 12:26
24deed1 to
012e38a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
picnixz
marked this pull request as draft
March 30, 2025 12:50
picnixz
force-pushed
the
infra/fix/tail-calling-interpreter-darwin-clang-131895
branch
from
March 30, 2025 13:04
f215493 to
e9e9d29
Compare
Member
Author
|
Ok... I forgot the |
Member
Author
|
It works \o/ |
picnixz
marked this pull request as ready for review
March 30, 2025 13:22
chris-eibl
approved these changes
Mar 30, 2025
chris-eibl
left a comment
chris-eibl
left a comment
Member
There was a problem hiding this comment.
LGTM!
So easy once you see the diff but sometimes less easy to get there :)
Member
Author
Yes. It's always a challenge to review YML code and code where glyphs are hard to distinguish sometimes (like, |
Fidget-Spinner
approved these changes
Mar 30, 2025
picnixz
enabled auto-merge (squash)
March 30, 2025 18:24
picnixz
deleted the
infra/fix/tail-calling-interpreter-darwin-clang-131895
branch
March 31, 2025 00:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configurefailures on x86_64/aarch64 apple-darwin/clang #131895