gh-138848: Add PNG optimization pre-commit hook#138849
Closed
StanFromIreland wants to merge 1 commit into
Closed
Conversation
Member
IIUC, the pre-commit hook should only apply when the file is changed? |
Member
Author
|
As you can see on this PR, running |
StanFromIreland
marked this pull request as ready for review
September 14, 2025 19:31
StanFromIreland
requested review from
a team,
AA-Turner,
freakboy3742,
gpshead,
hugovk,
mhsmith,
picnixz,
terryjreedy,
tiran and
vsajip
as code owners
September 14, 2025 19:31
Member
Author
|
As for git size: |
Member
|
I think you'll need exclude them: That way added files will be checked later. |
Member
|
FYI, the Using/mac-installer* files will be being updated shortly so please don't modify them now. |
StanFromIreland
force-pushed
the
as-pre-commit
branch
from
September 17, 2025 15:43
4e3e9f2 to
8b32f32
Compare
StanFromIreland
requested review from
FFY00,
barneygale,
corona10,
ericsnowcurrently,
erlend-aasland and
serhiy-storchaka
as code owners
September 17, 2025 15:43
Member
Author
|
Oops, I messed up a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC @zware The downside of adding the hook is we still have to deal with all of the little savings.
This currently uses the recommendations from their README.
📚 Documentation preview 📚: https://cpython-previews--138849.org.readthedocs.build/