[3.14] GH-139653: Only raise an exception (or fatal error) when the stack pointer is about to overflow the stack. (GH-141711)#141944
Merged
Conversation
… the stack pointer is about to overflow the stack. (pythonGH-141711) Only raises if the stack pointer is both below the limit *and* above the stack base. This prevents false positives for user-space threads, as the stack pointer will be outside those bounds if the stack has been swapped. Cherry-picked from commit c25a070
vstinner
approved these changes
Nov 25, 2025
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. Good idea to backport the whole internal documentation.
Contributor
|
Backporting this (together with #141661) makes KiCad work for me on Fedora 43. |
markshannon
approved these changes
Nov 25, 2025
markshannon
left a comment
markshannon
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this. Adding the docs is a good idea.
markshannon
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 0728b62 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141944%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
elliot-barn
added a commit
to ray-project/ray
that referenced
this pull request
Jul 17, 2026
CPython 3.14.0/3.14.1 fatally crash Ray async actors running on boost fiber stacks (python/cpython#141944, fixed upstream in 3.14.2), which kills the JobSupervisor on every Anyscale job. The py3.14 images are stuck on 3.14.0 for two reasons: the unpinned 'conda install python=3.14' resolve is frozen in the wanda layer cache, and the libffi=3.4.6 pin in base-deps forces conda to pick python 3.14.0 even on a fresh build (newer 3.14.x conda-forge builds require libffi>=3.5). Pin python 3.14.6 in base-deps and base-slim, and let 3.14 bring its own libffi. Verified: the async-actor repro crashes in rayproject/ray:nightly-py314-cpu (3.14.0) and passes with the same nightly cp314 wheel on 3.14.6. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
added a commit
to ray-project/ray
that referenced
this pull request
Jul 17, 2026
CPython 3.14.0/3.14.1 fatally crash Ray async actors running on boost fiber stacks (python/cpython#141944, fixed upstream in 3.14.2), which kills the JobSupervisor on every Anyscale job. The py3.14 base image resolves python 3.14.0 because the exact libffi=3.4.6 pin, installed as a separate conda step, re-solves the env and downgrades python to the only 3.14 build compatible with libffi<3.5. Replace the two-step install with a single solve using a libffi floor (>=3.4.6, keeping the intent of the original pin): every python version then resolves its newest patch release with a compatible libffi — 3.14.6 + libffi 3.5.2 for py3.14. Verified via dry-run for 3.10-3.14 and ctypes smoke tests on 3.10 (libffi 3.7.0) and 3.14 (libffi 3.5.2); the async-actor repro crashes on 3.14.0 and passes with the same nightly cp314 wheel on 3.14.6. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only raises if the stack pointer is both below the limit and above the stack base. This prevents false positives for user-space threads, as the stack pointer will be outside those bounds if the stack has been swapped.
Cherry-picked from commit c25a070
I'm also including the whole page of internal documentation, rather than ignore the conflict there.