bpo-45573: Use pkg-config for Modules/Setup#29164
Closed
tiran wants to merge 6 commits into
Closed
Conversation
tiran
force-pushed
the
configure_pkgconfig
branch
2 times, most recently
from
October 22, 2021 16:54
2413d8d to
30f60ac
Compare
tiran
force-pushed
the
configure_pkgconfig
branch
from
October 25, 2021 18:18
30f60ac to
4f5374f
Compare
``makesetup`` puts shared extensions into ``Modules/`` directory. Create symlinks from pybuilddir so the extensions can be imported. Note: It is not possible to use the content of pybuilddir.txt as a build target. Makefile evaluates target variables in the first pass. The pybuilddir.txt file does not exist at that point. Signed-off-by: Christian Heimes <christian@python.org>
Use pkg-config and a modified version of ``PKG_HAVE_DEFINE_WITH_MODULES`` to detect compiler flags and libraries for ``Modules/Setup``. For now CPython does not use any of the new flags in setup.py. We may expand the use of pkg-config once we are sure that it works properly on our target platforms. Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
configure_pkgconfig
branch
from
October 26, 2021 14:53
4f5374f to
310c4e3
Compare
brettcannon
removed their request for review
November 16, 2021 19:37
Member
|
Once this leaves the draft stage and my review is still desired, please feel free to add the review request back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pkg-config and a modified version of
PKG_HAVE_DEFINE_WITH_MODULESto detect compiler flags and librariesfor
Modules/Setup.For now CPython does not use any of the new flags in setup.py. We may
expand the use of pkg-config once we are sure that it works properly on
our target platforms.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45573