Skip to content

bpo-45847: Port _multiprocessing to PY_STDLIB_MOD (GH-29768)#29768

Merged
tiran merged 2 commits into
python:mainfrom
erlend-aasland:ac-multiproc
Nov 28, 2021
Merged

bpo-45847: Port _multiprocessing to PY_STDLIB_MOD (GH-29768)#29768
tiran merged 2 commits into
python:mainfrom
erlend-aasland:ac-multiproc

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 25, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

tiran
tiran reviewed Nov 25, 2021
View reviewed changes
Comment thread configure.ac Outdated
@erlend-aasland
erlend-aasland force-pushed the ac-multiproc branch 2 times, most recently from 36cf95f to 91c7cd9 Compare November 25, 2021 16:40
@erlend-aasland
erlend-aasland marked this pull request as ready for review November 25, 2021 16:40
@erlend-aasland

erlend-aasland commented Nov 25, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

AFAICS, HAVE_SEM_OPEN and POSIX_SEMAPHORES_NOT_ENABLED are handled by #ifdefs in the source code. We could add a check for $ac_cv_header_fcntl_h, but it's probably not needed.

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 26, 2021
@bedevere-bot

bedevere-bot commented Nov 26, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 0af5f50 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 26, 2021
tiran
tiran approved these changes Nov 26, 2021
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

I'm unsure about the semaphore extension. It is hard to test.

@erlend-aasland

erlend-aasland commented Nov 26, 2021

Copy link
Copy Markdown
Contributor Author

I'm unsure about the semaphore extension.

Me too. Let's ask on python-dev / Discourse.

@erlend-aasland
erlend-aasland marked this pull request as draft November 27, 2021 19:31
@erlend-aasland
erlend-aasland marked this pull request as ready for review November 27, 2021 19:41
@tiran tiran changed the title bpo-45847: Port _multiprocessing to PY_STDLIB_MOD bpo-45847: Port _multiprocessing to PY_STDLIB_MOD (GH-29768) Nov 28, 2021
@tiran
tiran merged commit aaf4222 into python:main Nov 28, 2021
@erlend-aasland
erlend-aasland deleted the ac-multiproc branch November 28, 2021 15:47
@tiran tiran mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @bedevere-bot @tiran @the-knights-who-say-ni