Skip to content

Make SimplePath path parameters positional-only #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaborbernat wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Make SimplePath path parameters positional-only #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions importlib_metadata/_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ class SimplePath(Protocol):
"""

def joinpath(
self, other: str | os.PathLike[str]
self, other: str | os.PathLike[str], /
) -> SimplePath: ... # pragma: no cover

def __truediv__(
self, other: str | os.PathLike[str]
self, other: str | os.PathLike[str], /
) -> SimplePath: ... # pragma: no cover

@property
Expand Down
1 change: 1 addition & 0 deletions newsfragments/542.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Marked the ``other`` parameter of ``SimplePath.joinpath`` and ``SimplePath.__truediv__`` positional-only, so ``pathlib.Path`` satisfies the protocol under type checkers that compare parameter names.