[ExecuTorch][WebGPU] Op-tests for q8ta_add#21192
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21192
Note: Links to docs will display an error until the docs builds have been completed. ❌ 48 New Failures, 29 Unrelated FailuresAs of commit 81af300 with merge base 4a26c64 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This was referenced Jul 22, 2026
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
JCNTH
added a commit
that referenced
this pull request
Jul 24, 2026
Pull Request resolved: #21192 Problem: The new `q8ta_add` int8 op needs golden coverage; its int8 output uses the int8-golden harness, and the `alpha` term (which the Vulkan glsl buffer path drops) must be pinned. Solution: A `q8ta_add` suite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test. Implementation: `cases.py` registers `basic`, `alpha=2.0` (fails byte-exact if the `a + alpha*b` term is dropped), and `nonzero_zp` cases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127); `golden_dtype="float32"` (int8 result is exactly representable). `test_q8ta_add.py` carries the delegation smoke test. ghstack-source-id: 406366821 @exported-using-ghexport Differential Revision: [D112257600](https://our.internmc.facebook.com/intern/diff/D112257600/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Problem: The new
q8ta_addint8 op needs golden coverage; its int8 output uses the int8-golden harness, and thealphaterm (which the Vulkan glsl buffer path drops) must be pinned.Solution: A
q8ta_addsuite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test.Implementation:
cases.pyregistersbasic,alpha=2.0(fails byte-exact if thea + alpha*bterm is dropped), andnonzero_zpcases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127);golden_dtype="float32"(int8 result is exactly representable).test_q8ta_add.pycarries the delegation smoke test.@exported-using-ghexport
Differential Revision: D112257600
Differential Revision: D112257600