FROMLIST: PCI: qcom: Set max OPP before DBI access during resume by ziyuezhang-123 · Pull Request #647 · qualcomm-linux/kernel

ziyuezhang-123 · 2026-06-03T09:00:51Z

During resume, qcom_pcie_icc_opp_update() may access DBI registers before the OPP votes are restored, which can trigger NoC errors.

Set the PCIe controller to the maximum OPP first in resume_noirq(), then proceed with link/DBI accesses. The OPP is later updated again based on the actual link bandwidth requirements.

Also introduce a small helper to reuse the max-OPP setup path shared with probe.

Fixes: 5b6272e ("PCI: qcom: Add OPP support to scale performance")
Link: https://lore.kernel.org/all/20260416-setmaxopp-v1-1-6a74e2d945a0@oss.qualcomm.com/

CRs-Fixed: 4536367

qswat-orbit-external · 2026-06-03T09:01:02Z

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4536367 on any of the following entities:

Entities:

kernel.qli.2.0

CR: 4536367

Please ensure the CR has a change task associated with at least one of the entities for this branch.

During resume, qcom_pcie_icc_opp_update() may access DBI registers before the OPP votes are restored, which can trigger NoC errors. Set the PCIe controller to the maximum OPP first in resume_noirq(), then proceed with link/DBI accesses. The OPP is later updated again based on the actual link bandwidth requirements. Also introduce a small helper to reuse the max-OPP setup path shared with probe. Fixes: 5b6272e ("PCI: qcom: Add OPP support to scale performance") Link: https://lore.kernel.org/all/20260416-setmaxopp-v1-1-6a74e2d945a0@oss.qualcomm.com/ Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com> Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>

qswat-orbit-external · 2026-06-03T09:03:16Z

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4536367 on any of the following entities:

Entities:

kernel.qli.2.0

CR: 4536367

Please ensure the CR has a change task associated with at least one of the entities for this branch.

psarma-qcom · 2026-06-15T09:38:16Z

qli-2.0 GA Critical Fix

qcomlnxci · 2026-06-15T11:09:49Z

Test jobs on af1c026

qcomlnxci · 2026-06-15T11:09:58Z

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
BT_ON_OFF	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
BT_SCAN	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
CPU_affinity	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
DSP_AudioPD	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	⚠️ skip	◻️
Ethernet	⚠️ skip	✅ Pass	◻️	◻️	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
GIC	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
IPA	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
Interrupts	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
OpenCV	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
PCIe	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	❌ Fail	❌ Fail	◻️	◻️	❌ Fail	❌ Fail	◻️
RMNET	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
UFS_Validation	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
USBHost	❌ Fail	❌ Fail	◻️	◻️	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	❌ Fail	❌ Fail	◻️	◻️	✅ Pass	✅ Pass	◻️
WiFi_OnOff	✅ Pass	❌ Fail	◻️	◻️	✅ Pass	✅ Pass	◻️
adsp_remoteproc	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	❌ Fail	◻️
hotplug	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
irq	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
kaslr	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
pinctrl	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
qcom_hwrng	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
remoteproc	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	❌ Fail	◻️
rngtest	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
shmbridge	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
smmu	❌ Fail	✅ Pass	◻️	◻️	✅ Pass	❌ Fail	◻️
watchdog	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
wpss_remoteproc	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️

qcomlnxci · 2026-06-15T12:25:07Z

Test jobs on af1c026

qcomlnxci · 2026-06-15T12:25:15Z

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
BT_ON_OFF	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
BT_SCAN	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
CPU_affinity	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
DSP_AudioPD	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	⚠️ skip	◻️
Ethernet	⚠️ skip	✅ Pass	◻️	◻️	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
GIC	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
IPA	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
Interrupts	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
OpenCV	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
PCIe	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	❌ Fail	❌ Fail	◻️	◻️	❌ Fail	❌ Fail	◻️
RMNET	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
UFS_Validation	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
USBHost	❌ Fail	❌ Fail	◻️	◻️	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	❌ Fail	❌ Fail	◻️	◻️	✅ Pass	✅ Pass	◻️
WiFi_OnOff	✅ Pass	❌ Fail	◻️	◻️	✅ Pass	✅ Pass	◻️
adsp_remoteproc	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	❌ Fail	◻️
hotplug	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
irq	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
kaslr	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
pinctrl	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
qcom_hwrng	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
remoteproc	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	❌ Fail	◻️
rngtest	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
shmbridge	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
smmu	❌ Fail	✅ Pass	◻️	◻️	✅ Pass	❌ Fail	◻️
watchdog	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️
wpss_remoteproc	✅ Pass	✅ Pass	◻️	◻️	✅ Pass	✅ Pass	◻️

qcomlnxci · 2026-06-16T11:26:11Z

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_ON_OFF	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_SCAN	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPU_affinity	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
DSP_AudioPD	✅ Pass	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	◻️
Ethernet	⚠️ skip	✅ Pass	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
GIC	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
IPA	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Interrupts	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
OpenCV	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
PCIe	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
RMNET	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
UFS_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
USBHost	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	❌ Fail	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
WiFi_OnOff	✅ Pass	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
adsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	✅ Pass	❌ Fail	◻️
hotplug	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
irq	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
kaslr	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
pinctrl	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
qcom_hwrng	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
rngtest	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
shmbridge	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
smmu	❌ Fail	✅ Pass	❌ Fail	✅ Pass	✅ Pass	❌ Fail	◻️
watchdog	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
wpss_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️

qcomlnxci · 2026-06-16T11:26:14Z

Test jobs on af1c026

ziyuezhang-123 requested review from a team, knaveen-qc, Nicolas Dechesne (ndechesne) and Shivendra Pratap (quicAspratap) June 3, 2026 09:00

ziyuezhang-123 force-pushed the hamoa_opp branch from a284ddb to af1c026 Compare June 3, 2026 09:03

krishnachaitanya-linux approved these changes Jun 15, 2026

View reviewed changes

Shiraz Hashim (shashim-quic) approved these changes Jun 15, 2026

View reviewed changes

Salendarsingh Gaud (sgaud-quic) added this to the qli-2.0 GA pull-request freeze milestone Jun 15, 2026

Salendarsingh Gaud (sgaud-quic) merged commit fffba0b into qualcomm-linux:qcom-6.18.y Jun 17, 2026
6 of 8 checks passed

Salendarsingh Gaud (sgaud-quic) mentioned this pull request Jun 22, 2026

Qcom 6.18.30 GA blockers for KLMT #755

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

FROMLIST: PCI: qcom: Set max OPP before DBI access during resume#647

FROMLIST: PCI: qcom: Set max OPP before DBI access during resume#647
Salendarsingh Gaud (sgaud-quic) merged 1 commit into
qualcomm-linux:qcom-6.18.yfrom
ziyuezhang-123:hamoa_opp

ziyuezhang-123 commented Jun 3, 2026 •

edited

Loading

Uh oh!

qswat-orbit-external Bot commented Jun 3, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 3, 2026

Uh oh!

psarma-qcom commented Jun 15, 2026

Uh oh!

qcomlnxci commented Jun 15, 2026

Uh oh!

qcomlnxci commented Jun 15, 2026

Uh oh!

qcomlnxci commented Jun 15, 2026

Uh oh!

qcomlnxci commented Jun 15, 2026

Uh oh!

qcomlnxci commented Jun 16, 2026

Uh oh!

qcomlnxci commented Jun 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

ziyuezhang-123 commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qswat-orbit-external Bot commented Jun 3, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 3, 2026

Uh oh!

psarma-qcom commented Jun 15, 2026

Uh oh!

qcomlnxci commented Jun 15, 2026

Test jobs on af1c026

Uh oh!

qcomlnxci commented Jun 15, 2026

Test Matrix

Uh oh!

qcomlnxci commented Jun 15, 2026

Test jobs on af1c026

Uh oh!

qcomlnxci commented Jun 15, 2026

Test Matrix

Uh oh!

qcomlnxci commented Jun 16, 2026

Test Matrix

Uh oh!

qcomlnxci commented Jun 16, 2026

Test jobs on af1c026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ziyuezhang-123 commented Jun 3, 2026 •

edited

Loading