Skip to content

arm64: dts: qcom: monaco-evk-emmc: Remove explicit UFS disablement#704

Merged
Salendarsingh Gaud (sgaud-quic) merged 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mchunara007:monaco-emmc-fix
Jun 17, 2026
Merged

arm64: dts: qcom: monaco-evk-emmc: Remove explicit UFS disablement#704
Salendarsingh Gaud (sgaud-quic) merged 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mchunara007:monaco-emmc-fix

Conversation

@mchunara007

@mchunara007 mchunara007 commented Jun 11, 2026

Copy link
Copy Markdown

The eMMC overlay currently explicitly disables the UFS host controller and overrides the vreg_l8a voltage. This causes unnecessary UFS disablement in scenarios where UFS is the boot medium and eMMC is used as secondary storage.

Since UFS and eMMC share a common VDD rail, their mutual exclusivity is now managed dynamically via DT-fixup logic. Remove these static entries from the overlay to allow flexible storage configurations.

CRs-Fixed: 4569877

@psarma-qcom

Copy link
Copy Markdown

"qli-2.0 GA Critical Fix"

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arm64: dts: qcom: monaco-evk-emmc: Remove explicit UFS disablement

submit upstream and bring as FROMLIST

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4569877 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4569877

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@mchunara007

mchunara007 commented Jun 12, 2026

Copy link
Copy Markdown
Author

CRs-Fixed: 4569877

qli-2.0 GA Critical Fix
qli-2.0 GA pull-request freeze

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4569877 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4569877
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

2 similar comments
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4569877 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4569877
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4569877 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4569877
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

…blement

The eMMC overlay currently explicitly disables the UFS host controller
and overrides the vreg_l8a voltage. This causes unnecessary UFS
disablement in scenarios where UFS is the boot medium and eMMC is used
as secondary storage.

Since UFS and eMMC share a common VDD rail, their mutual exclusivity is
now managed dynamically via DT-fixup logic. Remove these static entries
from the overlay to allow flexible storage configurations.

Link: https://lore.kernel.org/all/20260616130347.3096034-1-monish.chunara@oss.qualcomm.com/

Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
@mchunara007

Copy link
Copy Markdown
Author

arm64: dts: qcom: monaco-evk-emmc: Remove explicit UFS disablement

submit upstream and bring as FROMLIST

Submitted upstream, updated the commit subject and attached the link to the patch as suggested.

@qcomlnxci
qcomlnxci requested a review from a team June 16, 2026 13:11
@qlijarvis

Copy link
Copy Markdown

PR #704 — validate-patch

PR: #704

Verdict Issues Detailed Report
⚠️ 5 Full report

Final Summary

  1. Lore link present: Yes - https://lore.kernel.org/all/20260616130347.3096034-1-monish.chunara@oss.qualcomm.com/

  2. Lore link matches PR commits: Cannot verify - network access restricted; unable to fetch upstream patch for comparison

  3. Upstream patch status: In review - FROMLIST prefix indicates patch posted to mailing list but not yet merged; cannot verify current status due to network restrictions

  4. PR present in qcom-next: Not checked - would require kernel tree access (explicitly prohibited by task constraints)

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #704 - arm64: dts: qcom: monaco-evk-emmc: Remove explicit UFS disablement
Upstream commit: https://lore.kernel.org/all/20260616130347.3096034-1-monish.chunara@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL (cannot verify against upstream due to network restrictions)

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - network restricted; subject format is correct
Body preserves rationale Clear technical rationale provided
Fixes tag present/correct N/A No Fixes tag (not a bug fix)
Authorship preserved Author: Monish Chunara monish.chunara@oss.qualcomm.com
Backport note (if applicable) FROMLIST: prefix correctly indicates pending upstream patch

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-emmc.dtso Clean removal of 9 lines: UFS disable + vreg_l8a override

Commit Message Analysis

Strengths:

  • FROMLIST prefix: Correctly indicates this is from an upstream submission still under review
  • Clear rationale: Explains why UFS disablement is problematic (prevents UFS boot + eMMC secondary storage)
  • Technical context: Notes that UFS/eMMC mutual exclusivity is now handled via DT-fixup logic
  • Proper Link tag: Includes lore.kernel.org reference
  • Clean sign-off: Single Signed-off-by from patch author

Structure:

  • Subject line: Descriptive and follows kernel DTS conventions
  • Body: Two paragraphs explaining problem and solution
  • Trailers: Link tag followed by Signed-off-by (correct order)

Diff Analysis

Changes:

  • Removes &ufs_mem_hc { status = "disabled"; } block
  • Removes &vreg_l8a voltage override (2960000 µV)
  • Total: 9 lines deleted, 0 lines added

Technical correctness:

  • ✅ Removal is clean with no context changes
  • ✅ Diff shows proper context (3 lines before deletion)
  • ✅ File path is standard kernel DTS overlay location
  • ✅ Change aligns with commit message rationale

Issues

Network Restriction:

  • Cannot fetch upstream patch from lore.kernel.org to verify byte-for-byte match
  • Cannot verify if patch has been accepted/merged upstream
  • Cannot check for any upstream review comments or requested changes

Minor observations:

  • No Reviewed-by/Acked-by tags yet (expected for FROMLIST patches still in review)
  • Link tag timestamp (20260616) matches today's date - patch appears very recent

Verdict

Conditional approval pending network verification:
The patch structure, commit message format, and diff content appear correct. The FROMLIST prefix is appropriate, authorship is preserved, and the technical rationale is sound. However, full validation requires network access to:

  1. Verify the diff matches the lore.kernel.org submission exactly
  2. Check upstream review status and any requested changes
  3. Confirm no updates were posted after the Link tag timestamp

Recommendation: Merge conditionally - the patch follows kernel conventions and the change is straightforward, but ideally verify against lore.kernel.org when network access is available.

Final Summary

  1. Lore link present: Yes - https://lore.kernel.org/all/20260616130347.3096034-1-monish.chunara@oss.qualcomm.com/

  2. Lore link matches PR commits: Cannot verify - network access restricted; unable to fetch upstream patch for comparison

  3. Upstream patch status: In review - FROMLIST prefix indicates patch posted to mailing list but not yet merged; cannot verify current status due to network restrictions

  4. PR present in qcom-next: Not checked - would require kernel tree access (explicitly prohibited by task constraints)

@qlijarvis

Copy link
Copy Markdown

PR #704 — checker-log-analyzer

PR: #704
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27619995605

Checker Result Summary
Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check DTB validation passed
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance FAILED - lore.kernel.org link not accessible
tag-check N/A Not applicable for this branch
qcom-next-check FROMLIST: prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #704 - FROMLIST: arm64: dts: qcom: monaco-evk-emmc: Remove explicit UFS disablement
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27619995605

Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check DTB validation passed
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance FAILED - lore.kernel.org link not accessible
tag-check N/A Not applicable for this branch
qcom-next-check FROMLIST: prefix present

❌ check-patch-compliance

Root cause: The lore.kernel.org link in the commit message cannot be fetched by the b4 tool.

Failure details:

2026-06-16T13:27:12.6391194Z Something seems wrong with the provided link. Please verify it
2026-06-16T13:27:12.6391751Z Try below command to run locally-
2026-06-16T13:27:12.6392704Z b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260616130347.3096034-1-monish.chunara@oss.qualcomm.com/

Analysis:
The check-patch-compliance checker validates that FROMLIST/UPSTREAM patches match their upstream counterparts by fetching them from lore.kernel.org using b4. The failure indicates one of the following:

  1. Most likely: The patch was just submitted to the mailing list (timestamp: 2026-06-16 13:03:47 UTC) and lore.kernel.org has not yet indexed it. The lore archive typically has a delay of a few minutes to hours before new messages become accessible.

  2. Less likely: The message-ID in the Link tag is incorrect or the patch was not successfully delivered to the mailing list.

Fix:

Option 1 (Recommended): Wait for lore.kernel.org to index the patch

  • The patch was submitted very recently (same day as CI run)
  • Wait 15-30 minutes and re-run the CI checks
  • The lore archive should index the message and the checker will pass

Option 2: Verify the lore link manually

Reproduce locally:

b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260616130347.3096034-1-monish.chunara@oss.qualcomm.com/

If this command fails with "Unable to find message" or similar, the lore archive hasn't indexed it yet.

Verdict

1 non-blocking issue: The check-patch-compliance failure is a timing issue, not a code quality issue. The patch itself is clean (checkpatch passed, dtb-check passed). Once lore.kernel.org indexes the submitted patch (typically within 15-30 minutes), re-running the CI should result in all checks passing. The code changes are ready for merge from a technical perspective.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

@sgaud-quic
Salendarsingh Gaud (sgaud-quic) merged commit 8192503 into qualcomm-linux:qcom-6.18.y Jun 17, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants