Skip to content

arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay#843

Open
Rahul Samana (rahul-samana) wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
rahul-samana:rb3gen2-industrial-mezzanine-bt-uart-rename-qcom-6.18
Open

arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay#843
Rahul Samana (rahul-samana) wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
rahul-samana:rb3gen2-industrial-mezzanine-bt-uart-rename-qcom-6.18

Conversation

@rahul-samana

@rahul-samana Rahul Samana (rahul-samana) commented Jul 20, 2026

Copy link
Copy Markdown

Rename the RB3 Gen2 industrial mezzanine subtype 13 overlay and composed DTB target from the old M.2 Cologne name to a name describing the board-level Bluetooth-over-UART routing change.

This keeps the qcom-6.18.y kernel DTBO name aligned with the corresponding meta-qcom FIT metadata changes.

CRs-Fixed: 4615698

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4615698 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4615698
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

…T overlay

The RB3 Gen2 industrial mezzanine subtype 13 configuration describes a
board-level routing change where the M.2 slot is used for Bluetooth over
UART instead of Bluetooth over USB.

Rename the overlay and composed DTB target to describe the UART Bluetooth
routing rather than the old Cologne name.

Signed-off-by: Rahul Samana <rahul.samana@oss.qualcomm.com>
@rahul-samana
Rahul Samana (rahul-samana) force-pushed the rb3gen2-industrial-mezzanine-bt-uart-rename-qcom-6.18 branch from 511fa1e to 5cb39e3 Compare July 20, 2026 17:35
@qlijarvis

Copy link
Copy Markdown

PR #843 — validate-patch

PR: #843

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #843 - QCLINUX: arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay
Upstream commit: N/A (vendor-only QCLINUX: commit)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear explanation of rename rationale
Fixes tag present/correct N/A Not applicable for rename
Authorship preserved Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Consistent rename references
qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtso → qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtso Pure rename (100% similarity)

Issues

  • Integration presence: Commit is missing from both qcom-next and topics branches (per integration_presence_report.md). This is expected for a new PR but should be merged to qcom-next after approval.

Verdict

Merge after review. This is a vendor-only rename that clarifies the board configuration naming. The commit message is clear, the diff is consistent, and the change is purely cosmetic (no functional impact). The commit is not yet in qcom-next/topics, which is expected for a new PR.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — 1/1 commit missing from both qcom-next and topics (expected for new PR; will be present after merge)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: rename rb3gen2 industrial missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #843 — checker-log-analyzer

PR: #843
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29762611258

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Pre-existing tree issues only
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance QCLINUX: prefix not accepted
tag-check ⚠️ Cannot verify (target branch unknown)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #843 - arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29762611258

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Pre-existing tree issues only
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance QCLINUX: prefix not accepted
tag-check ⚠️ Cannot verify (target branch unknown)

❌ check-patch-compliance

Root cause: The commit uses QCLINUX: prefix, which is not in the checker's allowed list.

Failure details:

Checking commit: arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay
Commit summary does not start with a required prefix

Analysis:

The commit subject in the patch is:

QCLINUX: arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay

The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The QCLINUX: prefix is used for vendor-only changes with no upstream equivalent, but this is a known limitation of the checker — it will always fail for vendor-only commits.

This is not a patch defect. The QCLINUX: prefix is correct for a vendor-specific file rename that has no upstream equivalent.

Fix: None required. This is expected behavior for vendor-only changes.

Note: If this change were posted upstream or derived from upstream, the prefix should be changed to FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT: with an appropriate Link: trailer.


❌ dtb-check

Root cause: All errors are pre-existing tree issues, not introduced by this PR.

Failure details:

The PR only renames a file (qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtsoqcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtso) and updates the Makefile. No DTS content was changed.

The dtb-check log shows errors for:

  1. qcs6490-rb3gen2.dtb (base DTB)
  2. qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb (renamed overlay applied to base)

All errors are pre-existing issues in the tree:

Error Affected files Status
qcom,sc7280-inline-crypto-engine missing binding qcs6490-rb3gen2*.dtb Pre-existing (Issue #4 in log-patterns.md)
smsc,usb4604 missing binding qcs6490-rb3gen2*.dtb Pre-existing
pci1179,0623 unevaluated aspm-no-l1 qcs6490-rb3gen2*.dtb Pre-existing
pci1912,0014 unevaluated hub properties qcs6490-rb3gen2*.dtb Pre-existing
pwm:nvmem: [[401, 402]] is too short qcs6490-rb3gen2*.dtb Pre-existing (Issue #3 in log-patterns.md)
gp_mn_active-state invalid function name qcs6490-rb3gen2*.dtb Pre-existing
qcom,wcd9370-codec unevaluated properties *-bt-uart.dtb Pre-existing (overlay content unchanged)
serial@990000 both interrupts and interrupts-extended *-bt-uart.dtb Pre-existing (overlay content unchanged)

Analysis:

Since this PR is a pure file rename with no content changes, any dtb-check errors must have existed before the PR. The checker builds both the base DTB and the composed DTB (base + overlay), and all errors appear in both the original and renamed files.

These are recurring tree-wide issues documented in references/log-patterns.md Section 8:

  • Missing bindings for qcom,sc7280-inline-crypto-engine, smsc,usb4604
  • PWM nvmem array too short (qcs6490-rb3gen2 baseline issue)
  • Invalid pinctrl function names
  • Unevaluated PCI properties

Fix: None required for this PR. These are baseline tree issues that should be fixed separately.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb

⚠️ tag-check

Status: Cannot verify (target branch unknown due to network restrictions).

Analysis:

The tag-check verifies that every commit subject starts with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:), but only for branches other than qcom-next or qcom-next-staging.

The commit subject is:

QCLINUX: arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay

This commit does have a valid prefix (QCLINUX:), so:

  • If the target branch is not qcom-next or qcom-next-staging → ✅ PASS
  • If the target branch is qcom-next or qcom-next-staging → ⏭️ SKIP (check not required)

Verdict: The commit has a valid prefix. No action needed.


Verdict

1 blocker (check-patch-compliance) — but this is a known checker limitation, not a patch defect.

Summary:

  • checkpatch — No style issues
  • tag-check — Commit has valid QCLINUX: prefix
  • check-patch-compliance — Expected failure for vendor-only commits (known limitation)
  • dtb-check — All errors are pre-existing tree issues, not introduced by this PR

Recommendation:

Merge as-is. This is a clean file rename with no code changes. The check-patch-compliance failure is expected for vendor-only commits using the QCLINUX: prefix — this is a known checker limitation, not a patch defect. All dtb-check errors are pre-existing tree issues that should be addressed separately.

@qlijarvis

Copy link
Copy Markdown

PR #843 — validate-patch

PR: #843

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #843 - QCLINUX: arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay
Upstream commit: N/A (vendor-only commit)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit; no upstream source
Body preserves rationale Clear explanation of rename rationale
Fixes tag present/correct N/A Not applicable for file rename
Authorship preserved Consistent author and Signed-off-by
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Three references updated consistently from m2-cologne to bt-uart
qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtsoqcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtso Clean 100% rename; file content unchanged

Verdict

Merge as-is. This is a well-formed vendor-only commit that renames a device tree overlay and its Makefile references to better describe the hardware configuration (UART Bluetooth routing vs. the old Cologne codename). The rename is internally consistent and the commit message clearly explains the rationale.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Not in qcom-next/topics yet — expected for new vendor commit pending merge

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: rename rb3gen2 industrial missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #843 — checker-log-analyzer

PR: #843
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29764358384

Checker Result Summary
Checker Result Summary
checkpatch Passed
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Pre-existing pinctrl function validation error
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance QCLINUX: prefix not accepted
tag-check N/A (cannot determine target branch)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #843 - QCLINUX: arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29764358384

Checker Result Summary
checkpatch Passed
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Pre-existing pinctrl function validation error
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance QCLINUX: prefix not accepted
tag-check N/A (cannot determine target branch)

❌ check-patch-compliance

Root cause: Commit uses QCLINUX: prefix, which is not in the allowed list for check-patch-compliance.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The commit uses QCLINUX:, which is a vendor-internal prefix used in the tree but not accepted by this checker. This is a known limitation of the checker for vendor-only commits.

Fix options:

  1. If this change has been or will be posted upstream: Change prefix to FROMLIST: and add a Link: tag pointing to the lore.kernel.org URL.

  2. If this is truly vendor-only: The checker will always fail for QCLINUX: commits. This is expected behavior. However, since this is just a file rename with no functional changes, consider whether it needs the QCLINUX: prefix at all, or if it should be posted upstream as a cleanup.

Reproduce locally:

cd /path/to/kernel
./scripts/check-patch-compliance.sh --kernel-src . --base 94c6f41183c5b71f0cd81ca0c46bb17c3c1efa4e --head 5cb39e3a44ac0365714fb731ed0dba3d6c74cef5

❌ dtb-check

Root cause: Pre-existing pinctrl function name validation error exposed by building the renamed DTB.

Failure details:

qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb: pinctrl@f100000 (qcom,sc7280-pinctrl): 
  gp_mn_active-state: 'oneOf' conditional failed, one must be fixed:
  'gp_mn' is not one of ['atest_char', 'atest_char0', ..., 'gpio', ..., 'qup00', ...]
  from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sc7280-pinctrl.yaml#

Analysis:

This error appears on the renamed DTB (qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb) but did not appear on the old filename (qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtb) in the base build logs.

This is NOT a new error introduced by the PR — it's a pre-existing validation issue that is now being exposed because:

  1. The file rename is correct and follows proper naming conventions
  2. The DTB is now being built and validated (it may not have been built in the base)
  3. The underlying DTS content is unchanged (100% rename)

The error indicates that a pinctrl state node uses function = "gp_mn", which is not a valid function name in the qcom,sc7280-pinctrl binding. Valid function names include gpio, qup00-qup17, and many others, but not gp_mn.

This is a pre-existing tree issue in the qcs6490-rb3gen2-industrial-mezzanine.dtso or base DTS files, not caused by this PR's rename.

Fix (if required):

The pinctrl function name needs to be corrected in the source DTS/DTSO file:

# Find the offending pinctrl state
grep -r "gp_mn" arch/arm64/boot/dts/qcom/qcs6490-rb3gen2*.dts*

# Change function = "gp_mn" to the correct function (likely "gpio")
# in the gp_mn_active-state node

However, this fix is outside the scope of this PR, which is purely a file rename.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb

Verdict

2 blockers, but only 1 is actionable for this PR:

  1. dtb-check failure is pre-existing — not introduced by this PR. The rename is correct; the validation error exists in the underlying DTS content and should be fixed separately.

  2. check-patch-compliance failure is expectedQCLINUX: prefix is not accepted by this checker. If this is a vendor-only change, the failure is a known limitation. If the change can be posted upstream, switch to FROMLIST: + add Link: tag.

Recommendation:

  • If the target branch accepts QCLINUX: commits (e.g., qcom-next or qcom-next-staging), merge as-is and ignore the check-patch-compliance failure.
  • If the target branch requires upstream-linkable prefixes, either post the rename upstream and use FROMLIST:, or reconsider whether a vendor-only prefix is appropriate for a simple file rename.
  • The dtb-check failure should be addressed in a separate patch that fixes the pinctrl function name in the base DTS files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants