shikra: Enable CDSP cooling by dmantre · Pull Request #845 · qualcomm-linux/kernel

dmantre · 2026-07-21T12:52:15Z

Unlike the CPU, the CDSP does not throttle its speed automatically when it reaches high temperatures in shikra.
Set up CDSP cooling by throttling the cdsp, when it reaches 115°C.

CRs-Fixed: 4617103

qswat-orbit-external · 2026-07-21T12:52:23Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qswat-orbit-external · 2026-07-21T13:09:43Z

Merge Check Failed: CR Not Eligible for Merge

CR 4617103 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4617103
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qlijarvis · 2026-07-21T13:24:44Z

PR #845 — validate-patch

PR: #845

Verdict	Issues	Detailed Report
⚠️	5	Full report

Final Summary

Lore link present: Yes - https://lore.kernel.org/all/fe3ac7ae-8aa1-4ec2-8735-423d58eb9fec@oss.qualcomm.com/ (but not in standard Link: tag format)
Lore link matches PR commits: Cannot verify - lore patch was not fetched because the URL is not in the standard Link: tag format that the fetch tool recognizes
Upstream patch status: Cannot verify - no lore evidence available; FROMLIST prefix indicates patch is posted to mailing list but acceptance status unknown
PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #845 - FROMLIST: arm64: dts: qcom: shikra: Enable CDSP cooling
Upstream commit: https://lore.kernel.org/all/fe3ac7ae-8aa1-4ec2-8735-423d58eb9fec@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note

Subject matches upstream ⚠️ Cannot verify - lore patch not fetched

Body preserves rationale ✅ Clear problem statement and solution

Fixes tag present/correct N/A New feature, not a fix

Authorship preserved ⚠️ Cannot verify lore author without fetch; FROMLIST allows different submitter

Backport note (if applicable) N/A FROMLIST prefix, not a backport

Diff

File Status Notes

arch/arm64/boot/dts/qcom/shikra.dtsi ⚠️ Cannot verify against lore - adds CDSP cooling device and thermal trip point

Issues

Commit Message Format:
⚠️ Lore link not in standard format: The lore URL is present as a bare URL in the commit body. Per kernel conventions, it should be formatted as:
Link: https://lore.kernel.org/all/fe3ac7ae-8aa1-4ec2-8735-423d58eb9fec@oss.qualcomm.com/
This should appear after the Signed-off-by: trailer.
Verification Limitations:

⚠️ Cannot verify diff faithfulness: No lore evidence was fetched (lore_evidence/README.md reports "no lore.kernel.org Link tags found"). Without the upstream patch content, I cannot verify that the PR diff matches the lore posting.

⚠️ Cannot verify authorship chain: For FROMLIST commits, the original lore author's Signed-off-by: must be present. Cannot verify without fetching the lore patch.

⚠️ Cannot verify upstream status: Unable to determine if the patch has been accepted, rejected, or is still under review on the mailing list.

Integration Status:

⚠️ Partial presence in qcom-next/topics: The integration_presence_report.md shows "partial" status - subject or partial tree evidence found, but full change was not verified in either qcom-next or kernel topic branches.

Verdict

Request changes - The commit message format needs correction:

Required fix: Move the lore URL into a proper Link: tag after Signed-off-by:

Recommended: Re-fetch lore evidence with the corrected Link: tag to enable full validation of diff content, authorship, and upstream status

The diff content appears reasonable (adds CDSP cooling device node and thermal trip configuration), but cannot be verified as faithful to upstream without the lore patch.

Final Summary

Lore link present: Yes - https://lore.kernel.org/all/fe3ac7ae-8aa1-4ec2-8735-423d58eb9fec@oss.qualcomm.com/ (but not in standard Link: tag format)

Lore link matches PR commits: Cannot verify - lore patch was not fetched because the URL is not in the standard Link: tag format that the fetch tool recognizes

Upstream patch status: Cannot verify - no lore evidence available; FROMLIST prefix indicates patch is posted to mailing list but acceptance status unknown

PR present in qcom-next/topics: Partial - integration_presence_report.md shows "partial" status (1/1 commit has partial evidence but full change not verified in qcom-next or topics branches)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final

1/1 [PATCH] FROMLIST: arm64: dts: qcom: shikra: Enable CDSP cooling partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

qlijarvis · 2026-07-21T13:24:45Z

PR #845 — checker-log-analyzer

PR: #845
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29832061246

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	Passed
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	✅	Passed
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Missing `Link:` trailer
tag-check	✅	Subject has valid `FROMLIST:` prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #845 - FROMLIST: arm64: dts: qcom: shikra: Enable CDSP cooling
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29832061246
Target branch: qcom-6.18.y

Checker Result Summary

checkpatch ✅ Passed

dt-binding-check ⏭️ Skipped (no binding changes)

dtb-check ✅ Passed

sparse-check ⏭️ Skipped (no C/H changes)

check-uapi-headers ⏭️ Skipped (no UAPI changes)

check-patch-compliance ❌ Missing Link: trailer

tag-check ✅ Subject has valid FROMLIST: prefix

❌ check-patch-compliance

Root cause: The lore.kernel.org URL is present in the commit body but not formatted as a proper Link: trailer line.

Failure details:
Checking commit: FROMLIST: arm64: dts: qcom: shikra: Enable CDSP cooling
No 'Link' found in commit message
The commit contains the URL https://lore.kernel.org/all/fe3ac7ae-8aa1-4ec2-8735-423d58eb9fec@oss.qualcomm.com/ as a bare line in the commit body, but the checker requires it to be formatted as a trailer:
Link: https://lore.kernel.org/all/fe3ac7ae-8aa1-4ec2-8735-423d58eb9fec@oss.qualcomm.com/
Fix:
git rebase -i 373146dc22e4c54dc57dbf18e44aef6d58737f36   # mark commit as 'edit'
git commit --amend   # edit the commit message
# Change the bare URL line to:
# Link: https://lore.kernel.org/all/fe3ac7ae-8aa1-4ec2-8735-423d58eb9fec@oss.qualcomm.com/
git rebase --continue
The Link: trailer should be placed after the commit body and before or after the Signed-off-by: line (kernel convention typically places it after Signed-off-by:).

Reproduce locally:
cd /path/to/kernel
git log -1 --format="%B" c47c7072a2d3ea0baa8d52e851f0199d5c536cd3 | grep -q "^Link: " || echo "Missing Link: trailer"
Verdict

1 blocker to fix before merge: Add proper Link: trailer to the commit message. The patch content and style are correct; only the commit message format needs adjustment.

gauravkohli1 · 2026-07-22T05:40:16Z

LGTM, need to back port this change to 2.0

Komal Bajaj (Komal-Bajaj) · 2026-07-22T06:47:43Z

Add correct link:
https://lore.kernel.org/all/20260714-shikra-cdsp-v1-2-8402e060809e@oss.qualcomm.com/

Unlike the CPU, the CDSP does not throttle its speed automatically when it reaches high temperatures in shikra. Set up CDSP cooling by throttling the cdsp, when it reaches 115°C. Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com> https://lore.kernel.org/all/20260714-shikra-cdsp-v1-2-8402e060809e@oss.qualcomm.com/

qlijarvis · 2026-07-22T07:30:10Z

PR #845 — validate-patch

PR: #845

Verdict	Issues	Detailed Report
❌	7	Full report

Final Summary

Lore link present: Yes - but in incorrect format (bare URL instead of Link: tag)
Lore link matches PR commits: Cannot verify - network restrictions prevented lore fetch, but integration presence check shows PR contains MORE content than what exists in qcom-next/topics with the same subject
Upstream patch status: Cannot determine - network restrictions prevented thread analysis
PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #845 - FROMLIST: arm64: dts: qcom: shikra: Enable CDSP cooling
Upstream commit: https://lore.kernel.org/all/20260714-shikra-cdsp-v1-2-8402e060809e@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check Status Note

Subject matches upstream ⚠️ Cannot verify - lore fetch failed due to network restrictions

Body preserves rationale ⚠️ Cannot verify - lore fetch failed

Fixes tag present/correct ✅ No Fixes tag expected for new feature

Authorship preserved ⚠️ Cannot verify without lore source

Backport note (if applicable) N/A FROMLIST prefix used, not a backport

Link tag format ❌ Lore URL present but not in proper Link: tag format

Diff

File Status Notes

arch/arm64/boot/dts/qcom/shikra.dtsi ❌ PR contains MORE content than what exists in qcom-next/topics - extra cooling device definition

Issues

Critical: Content mismatch with integration branches

The integration presence check reveals that while a commit with the same subject exists in qcom-next (commit a4e928cb68f636db3a7f131ebfd93e59b6b8ba4b) and topics (commits 7a523b7c176a, a4e928cb68f6), the PR patch contains additional content not present in those commits:

Missing from qcom-next (2 lines):

nsp_alert1: nsp-alert1 {

trip = <&nsp_alert1>;

Missing from topics (5 lines):

cooling {

compatible = "qcom,qmi-cooling-cdsp";

cdsp_sw: cdsp_sw {

label = "cdsp_sw";

cooling-device = <&cdsp_sw

This indicates the PR patch either:

Contains changes from a different/newer revision than what was integrated

Has been modified locally with additional content beyond the lore posting

Combines multiple patches without proper attribution

Commit message format issue

The lore URL is present as a bare line in the commit body:
https://lore.kernel.org/all/20260714-shikra-cdsp-v1-2-8402e060809e@oss.qualcomm.com/
Per kernel conventions, it should be formatted as:
Link: https://lore.kernel.org/all/20260714-shikra-cdsp-v1-2-8402e060809e@oss.qualcomm.com/
Verdict

Do not merge. The PR patch contains significantly more content than what exists in the integration branches (qcom-next/topics), suggesting either:

The lore link points to an older revision that differs from the current PR content

Additional changes were added locally without proper attribution

Multiple patches were combined without documentation

Required actions:

Verify the lore link points to the correct revision matching this PR's content

If the PR contains additional changes beyond the lore posting, split them into separate commits with proper attribution

Fix the commit message to use proper Link: tag format

Ensure the PR content exactly matches what was posted to lore (for FROMLIST commits)

Final Summary

Lore link present: Yes - but in incorrect format (bare URL instead of Link: tag)

Lore link matches PR commits: Cannot verify - network restrictions prevented lore fetch, but integration presence check shows PR contains MORE content than what exists in qcom-next/topics with the same subject

Upstream patch status: Cannot determine - network restrictions prevented thread analysis

PR present in qcom-next/topics: Partial - commit with same subject exists (a4e928cb68f6 in qcom-next, 7a523b7c176a in topics) but PR patch contains 2-5 additional lines not present in those commits, indicating content divergence

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final

1/1 [PATCH] FROMLIST: arm64: dts: qcom: shikra: Enable CDSP cooling partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

qlijarvis · 2026-07-22T07:30:11Z

PR #845 — checker-log-analyzer

PR: #845
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29898269172

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	No binding changes
dtb-check	✅	Pre-existing warnings only
sparse-check	⏭️	No C/H file changes
check-uapi-headers	⏭️	No UAPI changes
check-patch-compliance	❌	Missing `Link:` trailer
tag-check	✅	Subject has valid `FROMLIST:` prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #845 - FROMLIST: arm64: dts: qcom: shikra: Enable CDSP cooling
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29898269172
Target branch: qcom-6.18.y

Checker Result Summary

checkpatch ✅ No style issues

dt-binding-check ⏭️ No binding changes

dtb-check ✅ Pre-existing warnings only

sparse-check ⏭️ No C/H file changes

check-uapi-headers ⏭️ No UAPI changes

check-patch-compliance ❌ Missing Link: trailer

tag-check ✅ Subject has valid FROMLIST: prefix

❌ check-patch-compliance

Root cause: The lore URL is present in the commit body but not formatted as a Link: trailer.

Failure details:
Checking commit: FROMLIST: arm64: dts: qcom: shikra: Enable CDSP cooling
No 'Link' found in commit message
The commit body currently has:
Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
https://lore.kernel.org/all/20260714-shikra-cdsp-v1-2-8402e060809e@oss.qualcomm.com/
The checker requires the URL to be formatted as a proper Link: trailer.

Fix:
Amend the commit to add the Link: trailer:
git rebase -i <base_sha>   # mark commit cb880691 as 'edit'
git commit --amend
Change the commit message from:
Set up CDSP cooling by throttling the cdsp, when it reaches 115°C.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
https://lore.kernel.org/all/20260714-shikra-cdsp-v1-2-8402e060809e@oss.qualcomm.com/
To:
Set up CDSP cooling by throttling the cdsp, when it reaches 115°C.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260714-shikra-cdsp-v1-2-8402e060809e@oss.qualcomm.com/
Complete the rebase:
git rebase --continue
git push --force-with-lease
Reproduce locally:
cd kernel-checkers
./check-patch-compliance.sh --pr 845 --repo qualcomm-linux/kernel
Verdict

1 blocker to fix before merge: Add Link: trailer to the commit message. The fix is trivial — just prepend Link: to the existing lore URL line. All other checkers passed or skipped appropriately.

dmantre requested review from a team, Komal Bajaj (Komal-Bajaj), knaveen-qc and yijiyang July 21, 2026 12:52

dmantre force-pushed the shikra-qmi-tmd-v1 branch from c47c707 to cb88069 Compare July 22, 2026 06:52

Uh oh!

Conversation

dmantre commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qswat-orbit-external Bot commented Jul 21, 2026

Uh oh!

qswat-orbit-external Bot commented Jul 21, 2026

Uh oh!

qlijarvis commented Jul 21, 2026

PR #845 — validate-patch

Final Summary

🔍 Patch Validation

Commit Message

Diff

Issues

Verdict

Final Summary

Deterministic Integration Presence

Integration Presence Report

Final Status

Uh oh!

qlijarvis commented Jul 21, 2026

PR #845 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ check-patch-compliance

Verdict

Uh oh!

gauravkohli1 commented Jul 22, 2026

Uh oh!

Komal Bajaj (Komal-Bajaj) commented Jul 22, 2026

Uh oh!

qlijarvis commented Jul 22, 2026

PR #845 — validate-patch

Final Summary

🔍 Patch Validation

Commit Message

Diff

Issues

Verdict

Final Summary

Deterministic Integration Presence

Integration Presence Report

Final Status

Uh oh!

qlijarvis commented Jul 22, 2026

PR #845 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ check-patch-compliance

Verdict

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dmantre commented Jul 21, 2026 •

edited

Loading