create temp context correctly

[cscheid]

This is a followup fix to #12329.

[cderv]

This cleanup was for singleFile render associated to const temp = globalTempContext();
So as this is already cleaned up globally, I didn't think we needed to do manual temp.cleanup in this case.

TBH, having those two different tempContext is for now not easy for me to reason about. I guess cleaning up in this finally step will not prevent or mess the last cleanup

1. Global cleanup register for quarto-session dir in TEMP
   

   quarto-cli/src/quarto.ts

   Line 185 in 6164de8

   onCleanup(cleanupSessionTempDir);

2. Called in Exit cleanup
   

   quarto-cli/src/core/cleanup.ts

   Lines 11 to 26 in 6164de8

   	export function onCleanup(handler: VoidFunction) {
   	cleanupHandlers.push(handler);
   	}
   	export function exitWithCleanup(code: number) {
   	// Not using cleanupHandlers.reverse() to not mutate the original array
   	for (let i = cleanupHandlers.length - 1; i >= 0; i--) {
   	const handler = cleanupHandlers[i];
   	try {
   	handler();
   	} catch (error) {
   	info("Error occurred during cleanup: " + error);
   	}
   	}
   	Deno.exit(code);
   	}

I guess this will be unused code now if we do cleanup as part of context.cleanup

[cscheid]

TBH, having those two different tempContext is for now not easy for me to reason about.

The old code is (demonstrably, see this PR!) hard for me to reason about too...

[cscheid]

And actually since this is also not a single-file render, I think we should replace globalTempContext() with a makeTempContext like we do in the other settings.

[cderv]

So, to sum up, globalTempContext() is no longer used. Quarto will now store all temp files locally in .quarto.

For sure this is clearer to read as more scoped.

Still, I think we should watch out for the side effects of moving from the OS global TEMP folder to the project local folder. The period before the final release will be a good test!

[cscheid]

Still, I think we should watch out for the side effects of moving from the OS global TEMP folder to the project local folder. The period before the final release will be a good test!

💯