[backport] Fix Windows paths with accented characters breaking dart-sass - #14274
Merged
Conversation
safeWindowsExec writes temp .bat files as UTF-8 (Deno default), but cmd.exe reads them using the OEM code page (e.g., CP850). Multi-byte UTF-8 characters like é (0xC3 0xA9) get misinterpreted, breaking paths with accented characters (e.g., C:\Users\Sébastien\). Add `chcp 65001 >nul` to switch cmd.exe to UTF-8 before the command line is parsed. Use CRLF line endings for correct .bat parsing.
3 tasks
5 tasks
cderv
added a commit
that referenced
this pull request
May 22, 2026
…rsand (#14535) * [backport] Bypass sass.bat on Windows to fix ampersand-in-username regression (#14534) The v1.9 introduction of safeWindowsExec broke dart-sass for users whose Windows profile path contains `&` (e.g., C:\Users\Tom & Jerry\). The ampersand is a cmd.exe command separator, so the temp .bat wrapper that safeWindowsExec writes is split mid-path and fails. The existing #14367 fallback to direct sass.bat execution does not help: Windows still spawns cmd.exe internally to interpret any .bat file, and the ampersand splits again. Backport of the dart.exe + sass.snapshot direct-invocation rewrite from PR #14273 (commit 4a7b6ce). Calling dart.exe through Deno.Command bypasses cmd.exe entirely and removes the whole class of .bat issues on Windows. The bundled dart-sass version is identical between v1.9 and main (DARTSASS=1.87.0), so the src/dart.exe + src/sass.snapshot layout is the same on disk. This also subsumes the #14367 enterprise group-policy fallback (no .bat = no policy block) and reinforces the #14267 accented-path fix already backported via #14274. Out of scope: other safeWindowsExec callers (texlive, zip, shell) still go through cmd.exe and remain vulnerable to ampersand in paths. Those have separate fixes upstream and are not covered by this backport. * Add regression test for ampersand in dart-sass paths (#14534) Cover the exact path pattern that broke v1.9 (e.g. C:\Users\Tom & Jerry\) to prevent re-regression. Mirrors the existing spaced/accented tests by junctioning the real dart-sass install dir into an ampersand-containing parent directory and asserting compilation succeeds. The junction itself is created via cmd /c mklink — Deno.Command passes each arg as a separate CreateProcess argument, so the ampersand in the target path is not interpreted by cmd.exe as a command separator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Backport from #14273
On Windows,
safeWindowsExecwrites temp.batfiles as UTF-8 butcmd.exereads them using OEM code page (CP850), garbling accented characters in paths (e.g.,C:\Users\Sébastien\).Adds
chcp 65001 >nulto switchcmd.exeto UTF-8 before the command line is parsed. Uses CRLF line endings for correct batch parsing.The full fix on main (#14273) also bypasses
sass.batentirely by callingdart.exedirectly — that larger change is not backported here.Fixes #14267