Bugfix/crossref acm template - #6136
Merged
Merged
Conversation
cderv
added a commit
that referenced
this pull request
Jul 17, 2026
The preceding hardening commits made three tests fail-capable that had been silently green, exposing pre-existing defects (all present on main): - editor-support: runEditorSupportCrossref called writer.releaseLock() before writer.close(), so close() threw "A writable stream is not associated with the writer". close() releases the lock itself - drop the releaseLock() call. - convert/issue-12318: the test converted docs/convert/issue-12318.qmd, which never existed. Add the fixture from GH #12318 (qmd->ipynb->qmd roundtrip repro) so the test exercises the round trip it claims to. - editor-support all.qmd: referenced since #6136 but never created. Add a combined-crossref fixture (sec/fig/tbl/eq/thm).
cderv
added a commit
that referenced
this pull request
Jul 17, 2026
The preceding hardening commits made three tests fail-capable that had been silently green, exposing pre-existing defects (all present on main): - editor-support: runEditorSupportCrossref called writer.releaseLock() before writer.close(), so close() threw "A writable stream is not associated with the writer". close() releases the lock itself - drop the releaseLock() call. - convert/issue-12318: the test converted docs/convert/issue-12318.qmd, which never existed. Add the fixture from GH #12318 (qmd->ipynb->qmd roundtrip repro) so the test exercises the round trip it claims to. - editor-support all.qmd: referenced since #6136 but never created. Add a combined-crossref fixture (sec/fig/tbl/eq/thm).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close quarto-journals/acm#25 (the smoke test using
tests/docs/crossrefs/editor-support/crossref-with-raw-latex.qmdshould replicate the condition of the upstream bug).