[docs] Update Material UI guide for MUI v4 - #1551
Merged
Merged
Conversation
SleeplessByte
approved these changes
Dec 27, 2020
SleeplessByte
left a comment
SleeplessByte
left a comment
Member
There was a problem hiding this comment.
Cool!
Have you also tried if these changes make your build work and make the plugin actually work with Material UI? I think yes from your PR message, but I want to be certain before I merge.
Contributor
Author
|
Yes indeed, this works great for me now (the issues I mentioned turned out to be unrelated). |
This was referenced Feb 7, 2021
This was referenced Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1179 as mentioned here. The plugin was out of date and no longer worked on the latest version of MUI.
Note: This does not update the generic JSS plugin (released as a separate node module) which may or may not still work (I haven't tried it with anything other than MUI). Rather than doing the work of maintaining a separate plugin for MUI, I think the community would be better served keeping this simpler guide updated and lettings folks customize according to need.
Thanks to @Herohtar and @6pm earlier for their work debugging this.