In a CocoaPod build, "Optional.h" will refer to folly/Optional.h unexpectedly

[mhorowitz]

Description

The CocoaPods setup works, but there are issues integrating it into larger projects. In particular, header files from folly (and maybe elsewhere?) pollute the user header filespace, and I don't know why.

Reproduction Steps and Sample Code

1. check out https://github.com/mhorowitz/native-navigation-boilerplate and apply this:

diff --git a/ios/Podfile b/ios/Podfile
index 3474dc5..556aa68 100644
--- a/ios/Podfile
+++ b/ios/Podfile
@@ -26,6 +26,8 @@ target 'ReactNativeStarter' do
     'DevSupport'
   ]

+  pod 'KSCrash'
+
   # Add any other dependencies here, including any 3rd party native libraries that you depend on for
   # React Native.
 end

2. To run pod and open in Xcode:

cd ios
pod install
open ReactNativeStarter.xcworkspace

3. Build it in Xcode. it will fail, probably in KSCrash's Demangle.cpp with an error about llvm::Optional. If you dig into this, you will eventually figure out that it is including folly/Optional.h instead. Xcode is generating a header map like .../DerivedData/ReactNativeStarter-bzdrkfxifzuvmgduxsjbskaldaxw/Build/Intermediates/Pods.build/Debug-iphonesimulator/KSCrash.build/KSCrash-project-headers.hmap which maps optional.h to Pods/Folly/folly/Optional.h, instead of the one inside KSCrash.

Solution

I have no idea. I am hoping someone who knows CocoaPods better than I can figure this out.

Additional Information

• React Native version: 844a18f
• Platform: iOS
• Development Operating System: MacOS Sierra
• Dev tools: Xcode 8.2.1, cocoapods 1.2.0

[javache]

I've found the same thing in #14100, where pod lib lint $POD_LINT_OPT --use-librarie would fail for the same reason.

[nico1510]

I think I have something related to this. I'm using react-native-fbsdk and when using CxxBridge the project doesn't compile and shows a warning 'non portable path to file Math.h' and an error and doesn't find the limits import (limits file not found).
When using the BatchedBridge everything compiles.

[javache]

For google-ability. This issue also manifests itself as:

Non-portable path to file '<String.h>; specified path differs in case from file name on disk.
No member named 'memcpy' in the global namespace
No member named 'memmove' in the global namespace

[rclai]

I've ran into this error when ejecting from create-react-native-app into ExpoKit mode. I added the additional pod specs per this.

And I'm now stuck here.

[sivakumar-cf]

When I update from react-native 0.44.3 to 0.45.1, I got a build issue in iOS.

limits File not found
in Folly/Math.h

pod 'React', :path => '../node_modules/react-native', :subspecs => [
'Core',
'CxxBridge',
'RCTText',
'RCTNetwork',
'RCTWebSocket', # needed for debugging
'RCTImage',
'RCTNetwork',
# Add any other subspecs you want to use in your project
'DevSupport'
]
# To use CocoaPods with React Native, you need to add this specific Yoga spec as well
pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

# Third party deps
pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
pod 'GLog', :podspec => '../node_modules/react-native/third-party-podspecs/GLog.podspec'
pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

Please help me to resolve this build error. Thanks in Advance.

[mhorowitz]

I'm hopeful I've worked around this. If you're experiencing this problem, please try your app against a version of RN including the above rev and post what happens. Thanks!

[ptomasroos]

Will try right away and report back!

[zhunt11]

I am seeing a similar issue after having gotten updated to v0.45.1.

Unable to find a specification for Follydepended upon byReact/CxxBridge``

#14612

[ragnorc]

Any updates on this? Does it now work with 0.46?

[mhorowitz]

I've landed fixes for all the CocoaPods+CxxBridge issues I am aware of. They have just been cherry picked into v0.47.0-rc.1, so if you want to try this out, you must be using this version or later. You can do this in your package.json file like this:

"react-native": "0.47.0-rc.1"

For any earlier version of React Native, you cannot use CocoaPods with CxxBridge. You need to use the BatchedBridge subspec in your Podfile. This will continue to work until the CxxBridge CocoaPods podspec is stable.

If you continue to have problems, you must post the following information:

• Your Podfile
• The version of react-native you are building against
• The command or Xcode target which failed
• The error messages or other diagnostics.

If it works for you, that would be great to know, too!