Work around Electron Windows command-line args quirk#53510
Closed
motiz88 wants to merge 1 commit into
Closed
Conversation
Summary: Changelog: [Internal] Electron imposes a [strange undocumented limitation](electron/electron#13039) on the format of command-line arguments, which for some reason only affects Windows. Basically, the command line is truncated after the first argument that looks like a URL. Electron's recommendation for avoiding this is to prefix the argument list with `--`, but I prefer switching to a different arg format (`--x=y` instead of `--x y`) that will prevent us from ever running into this issue. NOTE: I will follow up with a diff to harden arg parsing in our Electron code so that it only accepts the `--x=y` format. Differential Revision: D81237713
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81237713 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Aug 28, 2025
Summary: Changelog: [Internal] Electron imposes a [strange undocumented limitation](electron/electron#13039) on the format of command-line arguments, which for some reason only affects Windows. Basically, the command line is truncated after the first argument that looks like a URL. Electron's recommendation for avoiding this is to prefix the argument list with `--`, but I prefer switching to a different arg format (`--x=y` instead of `--x y`) that will prevent us from ever running into this issue. NOTE: I will follow up with a diff to harden arg parsing in our Electron code so that it only accepts the `--x=y` format. Differential Revision: D81237713
Contributor
|
This pull request has been merged in d1a9990. |
Collaborator
|
This pull request was successfully merged by @motiz88 in d1a9990 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Electron imposes a strange undocumented limitation on the format of command-line arguments, which for some reason only affects Windows. Basically, the command line is truncated after the first argument that looks like a URL.
Electron's recommendation for avoiding this is to prefix the argument list with
--, but I prefer switching to a different arg format (--x=yinstead of--x y) that will prevent us from ever running into this issue.NOTE: I will follow up with a diff to harden arg parsing in our Electron code so that it only accepts the
--x=yformat.Differential Revision: D81237713