-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Download React Native artifacts from the proxy cache server first #57325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coado
wants to merge
13
commits into
react:main
Choose a base branch
from
coado:@coado/maven-repo-switch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
854f0b7
integrate proxy server
coado e7d7174
reduce artifacts exists calls on iOS builds
coado fa22164
reduce artifacts exists calls in ruby
coado db9f786
fix lint issues
coado 4ce6cd3
undo hermes-compiler version change
coado 479acf1
Add reactNativeMavenCacheEnabled flag for toggling usage of Maven cac…
coado 60b7f96
refactor ruby files
coado 0e5edbc
change url to https://repo.reactnative.dev/
coado aa5c20d
change repo url in test files
coado c0b6619
add maven2 to url
coado f3262d5
set cache to false by default
coado 4d1499e
add iOS tests
coado f40fea3
check env var on Android
coado File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
packages/react-native/scripts/cocoapods/__tests__/maven_cache_flag-test.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| # | ||
| # This source code is licensed under the MIT license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
|
|
||
| require "test/unit" | ||
| require_relative "../utils.rb" | ||
| require_relative "../../../sdks/hermes-engine/hermes-utils.rb" | ||
|
|
||
| class MavenCacheFlagTests < Test::Unit::TestCase | ||
| def setup | ||
| @original_value = ENV['RCT_REACT_NATIVE_MAVEN_CACHE_ENABLED'] | ||
| ENV.delete('RCT_REACT_NATIVE_MAVEN_CACHE_ENABLED') | ||
| end | ||
|
|
||
| def teardown | ||
| if @original_value == nil | ||
| ENV.delete('RCT_REACT_NATIVE_MAVEN_CACHE_ENABLED') | ||
| else | ||
| ENV['RCT_REACT_NATIVE_MAVEN_CACHE_ENABLED'] = @original_value | ||
| end | ||
| end | ||
|
|
||
| def test_mavenCache_isDisabledByDefault | ||
| assert_false(ReactNativePodsUtils.react_native_maven_cache_enabled?) | ||
| assert_false(react_native_maven_cache_enabled?) | ||
| end | ||
|
|
||
| def test_mavenCache_isEnabledWhenExplicitlySetToTrue | ||
| ENV['RCT_REACT_NATIVE_MAVEN_CACHE_ENABLED'] = 'true' | ||
|
|
||
| assert_true(ReactNativePodsUtils.react_native_maven_cache_enabled?) | ||
| assert_true(react_native_maven_cache_enabled?) | ||
| end | ||
|
|
||
| def test_mavenCache_isDisabledWhenExplicitlySetToFalse | ||
| ENV['RCT_REACT_NATIVE_MAVEN_CACHE_ENABLED'] = 'false' | ||
|
|
||
| assert_false(ReactNativePodsUtils.react_native_maven_cache_enabled?) | ||
| assert_false(react_native_maven_cache_enabled?) | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a comment mentioning that this is added "first" intentionally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 479acf1