[LOCAL] Fix CI: build rntester dynamic-frameworks lane from source#57615
Merged
cipolleschi merged 1 commit intoJul 20, 2026
Merged
Conversation
cipolleschi
force-pushed
the
fix/0.87-ci-dynamic-frameworks-from-source
branch
from
July 20, 2026 15:37
27abaf4 to
9dc83e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #57614. That PR fixed the
Podfile.lockversion staleness, which unblocked thetest_ios_rntesterlanes but advancedtest_ios_rntester_dynamic_frameworks(Debug + Release) to the next error:Root cause
test_ios_rntester_dynamic_frameworksis meant to be the from-source dynamic-frameworks lane. But the CocoaPods install never disabled the prebuilt defaults:RCT_USE_PREBUILT_RNCOREandRCT_USE_RN_DEPboth default to'1'(react_native_pods.rb), so the pods resolve to the released Maven artifacts whenever they exist.mainthe version is1000.0.0, which has no Maven artifact (404) →build_from_source=true→ the lane builds from source and passes.0.87.0-rc.1) does have Maven artifacts, so the lane consumes the released React core tarball — which predates theReactNativeHeaders.xcframeworklayout that current HEAD's podspec requires → the prepare_command fails.Fix
Add an explicit
build-from-sourceinput to thetest-ios-rntesteraction that exportsRCT_USE_PREBUILT_RNCORE=0andRCT_USE_RN_DEP=0, and set it only on thetest_ios_rntester_dynamic_frameworksjob. This makes that lane truly build from source (its documented intent, matchingmain), independent of what's published to Maven, without changing behavior for any other caller of the shared action (test_ios_rntester,test_ios_rntester_ruby_3_2_0leave it at the defaultfalse).Changelog:
[Internal] -
Test plan
Reproduced the lane locally against the rc.1 lock:
pod update hermes-engine --no-repo-updatewith the prebuilt defaults pulls the Maven rc.1 React core tarball and fails on missingReactNativeHeaders.xcframework.RCT_USE_PREBUILT_RNCORE=0 RCT_USE_RN_DEP=0 USE_FRAMEWORKS=dynamic): both resolve toBuilding from source: true,React-Core-prebuilt/ prebuiltReactNativeDependenciesare removed, andpod installcompletes successfully.