Skip to content

feat: change the aria label on github and personal site with adding aria-hidden for icons #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rully-saputra15 wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −9
Open

feat: change the aria label on github and personal site with adding aria-hidden for icons #8553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions src/components/MDX/TeamMember.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,22 @@ export function TeamMember({
<div
className="hidden sm:block basis-2/5 rounded overflow-hidden relative"
style={{width: 300, height: 250}}>
<Image src={photo} layout="fill" objectFit="cover" alt={name} />
<Image
src={photo}
layout="fill"
objectFit="cover"
alt={`${name}'s profile picture`}
/>
</div>
<div
style={{minHeight: 300}}
className="block w-full sm:hidden flex-grow basis-2/5 rounded overflow-hidden relative">
<Image src={photo} layout="fill" objectFit="cover" alt={name} />
<Image
src={photo}
layout="fill"
objectFit="cover"
alt={`${name}'s profile picture`}
/>
</div>
<div className="ps-0 sm:ps-6 basis-3/5 items-start">
<H3 className="mb-1 sm:my-0" id={permalink}>
Expand All @@ -113,7 +123,7 @@ export function TeamMember({
aria-label={`${name} on Twitter`}
href={`https://twitter.com/${twitter}`}
className="hover:text-primary hover:underline dark:text-primary-dark flex flex-row items-center">
<IconTwitter className="pe-1" />
<IconTwitter className="pe-1" aria-hidden="true" />
{twitter}
</ExternalLink>
</div>
Expand All @@ -124,7 +134,7 @@ export function TeamMember({
aria-label={`${name} on Threads`}
href={`https://threads.net/${threads}`}
className="hover:text-primary hover:underline dark:text-primary-dark flex flex-row items-center">
<IconThreads className="pe-1" />
<IconThreads className="pe-1" aria-hidden="true" />
{threads}
</ExternalLink>
</div>
Expand All @@ -135,27 +145,27 @@ export function TeamMember({
aria-label={`${name} on Bluesky`}
href={`https://bsky.app/profile/${bsky}`}
className="hover:text-primary hover:underline dark:text-primary-dark flex flex-row items-center">
<IconBsky className="pe-1" />
<IconBsky className="pe-1" aria-hidden="true" />
{bsky}
</ExternalLink>
</div>
)}
{github && (
<div className="me-4">
<ExternalLink
aria-label="GitHub Profile"
aria-label={`${name} on Github`}
href={`https://github.com/${github}`}
className="hover:text-primary hover:underline dark:text-primary-dark flex flex-row items-center">
<IconGitHub className="pe-1" /> {github}
<IconGitHub className="pe-1" aria-hidden="true" /> {github}
</ExternalLink>
</div>
)}
{personal && (
<ExternalLink
aria-label="Personal Site"
aria-label={`${name}'s personal site`}
href={`https://${personal}`}
className="hover:text-primary hover:underline dark:text-primary-dark flex flex-row items-center">
<IconLink className="pe-1" /> {personal}
<IconLink className="pe-1" aria-hidden="true" /> {personal}
</ExternalLink>
)}
</div>
Expand Down
Loading