[#1257] Storyline banner + ref preservation + browse CTA - #1295
Conversation
Add StorylineSprintBanner.tsx: dismissible bottom banner on storyline pages with "Buy-Back Sprint is live" + Join CTA link to /airdrop. Dismiss stored in localStorage. ShareButtons already appends ?ref=CODE (verified, no change needed). Add "Browse storylines →" CTA pointing to / (T0.1 decision) in the pre-activation state on /airdrop. Closes #1257 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
left a comment
realproject7
left a comment
There was a problem hiding this comment.
@re2 review — APPROVE ✅
Checked against issue #1257 acceptance criteria:
| Criterion | Status |
|---|---|
| Banner on storyline pages, dismissible, low-profile | ✅ localStorage dismiss |
Share button preserves ?ref=CODE |
✅ existing behavior verified |
"Browse storylines" CTA → / (T0.1 decision) |
✅ Next.js Link |
| Version 1.40.1 → 1.40.2 (patch) | ✅ |
Code notes:
dismissedinitialized totrueprevents hydration flash (SSR-safe)- localStorage read in
useEffect— correct client-side pattern - Banner positioned after ShareButtons in storyline page (low-profile, bottom of content)
- Accent-themed subtle styling (
border-accent/30 bg-accent/5) - Join CTA links to
/airdrop, dismiss button with×symbol
No issues found.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The PR covers the placement, dismiss behavior, share URL verification, and / browse-storylines target, but the new storyline banner does not meet the scoped banner content for #1257. The issue explicitly calls for the banner to show the PlotLink Buy-Back Sprint context, campaign day, and current FDV.
Findings
- [medium] Storyline sprint banner omits the required Day X/90 and current FDV campaign context.
- File:
src/components/airdrop/StorylineSprintBanner.tsx:23 - Suggestion: Populate the banner with the scoped copy/data, e.g.
PlotLink Buy-Back Sprint · Day X/90 · current FDV, using existing campaign start/end/current FDV data from the airdrop status/config path. Keep the low-profile/dismissible treatment.
- File:
Decision
Requesting changes because the banner is the primary deliverable for #1257 and its required content is missing. Ref preservation in ShareButtons and the / browse-storylines CTA target look correct. Note: GitHub lint/e2e Actions did not run for this branch; only Vercel ignored-build statuses are present.
Fetch /api/airdrop/status to populate campaign context: "Buy-Back Sprint · Day X/90 · FDV $X". Renders after status loads, keeps dismissible low-profile treatment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The requested banner context has been added: the storyline banner now fetches /api/airdrop/status and displays campaign day plus current FDV while retaining the low-profile dismissible treatment. The existing share URL path preserves encoded ?ref=CODE, and the /airdrop Browse storylines CTA targets / per the locked T0.1 decision.
Findings
- None.
Decision
Approved. Note: GitHub lint/e2e Actions did not run for this branch; only Vercel ignored-build statuses are present.
2 participants
Summary
ShareButtonsalready appends?ref=CODEto share URLs (verified, no change needed)/(T0.1 decision) in pre-activation state on /airdropVersion
1.40.1 → 1.40.2
Closes #1257
🤖 Generated with Claude Code