Remove unused conn_port methods#317
Open
nvasilevski wants to merge 1 commit into
Open
Conversation
Net::HTTP stopped calling conn_port when proxy connection selection was inlined in d07a2fb in 2012. That refactor also stopped including ProxyDelta, leaving both private conn_port implementations unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Net::HTTP#conn_portandNet::HTTP::ProxyDelta#conn_porthave no callers.Commit d07a2fb changed the connection path to select
portorproxy_portdirectly and stopped includingProxyDeltain 2012. Both private helpers have been unused since.This removes the two unreachable methods while retaining the remaining
ProxyDeltacompatibility surface.Verification:
bundle exec rake test— 188 tests, 884 assertions, 0 failures.