ZJIT: Fix kwargs handling in invokeblock ifunc specialization#17971
Open
dak2 wants to merge 1 commit into
Open
ZJIT: Fix kwargs handling in invokeblock ifunc specialization#17971dak2 wants to merge 1 commit into
dak2 wants to merge 1 commit into
Conversation
Contributor
|
Thanks! Can you please add an HIR opt test? We rely a lot on those. |
dak2
force-pushed
the
zjit-fix-invokeblock-ifunc-kwarg
branch
3 times, most recently
from
July 20, 2026 02:19
68480eb to
548244c
Compare
Contributor
Author
|
@tekknolagi |
gen_invokeblock_ifunc drops the callinfo and passes argv straight to rb_vm_yield_with_cfunc, which hardcodes kw_splat = 0, so keyword arguments lost their keyword-ness. Gate the ifunc specialization on block_call_inlinable, the same check used for the inline ISEQ path.
dak2
force-pushed
the
zjit-fix-invokeblock-ifunc-kwarg
branch
from
July 20, 2026 02:33
548244c to
ed222bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: Shopify#1018
gen_invokeblock_ifunc drops the callinfo and passes argv straight to rb_vm_yield_with_cfunc, which hardcodes kw_splat = 0, so keyword arguments lost their keyword-ness.
Gate the ifunc specialization on block_call_inlinable, the same check used for the inline ISEQ path.