Require offset when parsing RFC3339#72
Open
bdewater-thatch wants to merge 1 commit into
Open
Conversation
RFC3339 requires a Z designator or explicit numeric offset. Reject offset-less timestamps instead of passing them to Time.new, which interprets them in local time.
Contributor
|
Thank you for the report. I'm checking with one of the Rails maintainers in #73 to see if this PR will pass the Rails specs. If so, I'll merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#59 introduced
Time.rfc3339. Parsing RFC3339 requires a Z designator or explicit numeric offset. This PR rejects offset-less timestamps instead of passing them to Time.new, which interprets them in local time.The Rails unit tests for same method surfaced the difference in implementations: rails/rails#58172
DateTime also correctly raises: