Skip to content

Simplify example in the README#18

Merged
perryqh merged 1 commit into
rubyatscale:mainfrom
fxn:patch-1
Jun 7, 2024
Merged

Simplify example in the README#18
perryqh merged 1 commit into
rubyatscale:mainfrom
fxn:patch-1

Conversation

@fxn

@fxn fxn commented Jun 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Just something I spotted reading the README.

Since member? accesses github.members:

def github
  raw_github = @team.raw_hash['github'] || {}

  GithubStruct.new(
    raw_github['team'],
    raw_github['members'] || []
  )
end

we can simplify the predicate.

@fxn

fxn commented Jun 5, 2024

Copy link
Copy Markdown
Contributor Author

/cc @technicalpickles

perryqh
perryqh approved these changes Jun 7, 2024
View reviewed changes

@perryqh perryqh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@perryqh
perryqh merged commit b8db982 into rubyatscale:main Jun 7, 2024
@fxn
fxn deleted the patch-1 branch June 8, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perryqh perryqh perryqh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fxn @perryqh