Skip to content

consider using === in network blacklist matching #405

Description

@Nakilon

The String#match is doing funny things

irb(main):023:0> "vg?1".match "vg?1"
=> nil
irb(main):024:0> "g?1".match "g?1"
=> #<MatchData "1">

here


and since you send regex on url and not vice versa, I believe it isn't intended.
So I propose to make it like this instead:

      def match?(regexp)
        not not regexp === url
      end

because it was too surprising that when I added an exact url string it didn't match, such as "https://telegram.org/img/tgme/pattern.svg?1".

Have no time to come up with a PR, just patched in a fork.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions