UIkit 3.25 LESS backports and less.php 5.5.0 for PHP 8.5#7
Open
BernhardBaumrock wants to merge 2 commits into
Open
UIkit 3.25 LESS backports and less.php 5.5.0 for PHP 8.5#7BernhardBaumrock wants to merge 2 commits into
BernhardBaumrock wants to merge 2 commits into
Conversation
Backport :is()/:not()/:where()/:has() comma-separated selector parsing from elabx/less.php#1, and native CSS color function passthrough for rgba(..., var(...)) from wikimedia/less.php 5.5.0 (T405815). Co-authored-by: Cursor <cursoragent@cursor.com>
- Bundle less.php 5.5.0 with upstream PHP 8.5 deprecation fixes - Keep comma-separated pseudo-class selector backport in 5.5.0 parser - Register 5.5.0 in versions.json and bump module version to 8 Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Owner
Contributor
Author
|
@ryancramerdesign yeah I saw your comments on wikimedia/less.php#136 but as the less module was not up to date and I had to make a client's website work I went ahead and updated my fork. I also added elabx's fix, so I guess my PR does that same that your latest version does. |
Owner
|
Okay sounds good. Let me know if I'm missing anything still and will add
it. I did the Uikit upgrade today and your upgrade routine for PW makes it
so nice and easy.
…On Thu, Jul 9, 2026 at 6:25 PM Bernhard Baumrock ***@***.***> wrote:
*BernhardBaumrock* left a comment (ryancramerdesign/Less#7)
<#7 (comment)>
@ryancramerdesign <https://github.com/ryancramerdesign> yeah I saw your
comments on wikimedia/less.php#136
<wikimedia/less.php#136> but as the less module
was not up to date and I had to make a client's website work I went ahead
and updated my fork. I also added elabx's fix, so I guess my PR does that
same that your latest version does.
—
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AACQEUFNFTA2UL25RUHMDLT5EALW5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJTGAYDSNRYGUZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4930096852>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQEUEGA3N3J5TJI3JUFQL5EALW5AVCNFSNUABFKJSXA33TNF2G64TZHMZTOMBYGA4TQMJUHNEXG43VMU5TIOBVGAZDKNBVGA2KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AACQEUFMT2FGO3RUGSPSO4L5EALW5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJTGAYDSNRYGUZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AACQEUBHSKB4ALVE2T4DWHL5EALW5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJTGAYDSNRYGUZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi Ryan — our forks diverged after your v0.0.6 release (we both added AdminStyle + less.php 4.1.1/5.4.0 independently). I've synced with your
mainand this PR contains only the additive changes on top of your current branch.1. UIkit 3.25 / AdminThemeUikit LESS compatibility (backports to 4.1.1 + 5.4.0)
AdminThemeUikit 3.25 uses modern CSS selectors and color functions that the bundled less.php versions don't parse yet. Backported:
:is(),:not(),:where(),:has()) — from elabx/less.php#1 (Less.js 4.2 / Support nesting pseudo-classes like ":not" or ":is" (Less.js 4.2) wikimedia/less.php#136)rgba(0, 0, 0, var(--opacity))— from wikimedia/less.php 5.5.0 (T405815)2. Wikimedia less.php 5.5.0
versions.json; module version → 7Context
These changes were developed while using the module in production (AdminThemeUikit + PHP 8.5). Happy to adjust versioning or split into separate PRs if you prefer.
Test plan
rgba(0, 0, 0, var(--opacity))passes through as native CSSMade with Cursor