bug: Menu should support `aria-disabled="true"` like Button does

[brianhelba]

Reproduction URL (Required)

https://play.tailwindcss.com/u2cuWzgQrC

What version of daisyUI are you using?

v5.6.7

Which browsers are you seeing the problem on?

All browsers

Describe your issue

PR #4432 updated the button component to support aria-disabled="true":

https://github.com/saadeghi/daisyui/blob/master/packages/daisyui/src/components/button.css#L359-L360

.btn-disabled,
.btn:is(:disabled, [disabled], [aria-disabled="true"]) {

The menu component wasn't updated to match. It only supports the .menu-disabled class:

https://github.com/saadeghi/daisyui/blob/master/packages/daisyui/src/components/menu.css#L129-L130

&.menu-disabled {
  @apply text-base-content/20 pointer-events-none;
}

With buttons, I can write <button aria-disabled="true"> and get both the correct visual styling and the correct accessibility semantics in one attribute. With menu items, I have to add the .menu-disabled class for the visual styling and then separately manage the ARIA attribute myself to get the same result.

Menu items should support aria-disabled="true" the same way buttons do, so that a single attribute handles both concerns.

[github-actions]

Thank you @brianhelba for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

[pdanpdan]

<button aria-disabled="true"> is very wrong :)
It should never be used - use disabled
It is only visual and a11y, and does not solve the functional disabling of the button

[saadeghi]

Yes @pdanpdan. We should add styles for <button disabled> tho

https://play.tailwindcss.com/zjxm0xyvLK

[saadeghi]

I will add it tomorrow

[pdanpdan]

I didn't mean we should not improve menu. I was talking just about the usage of aria-disabled on buttons.

[saadeghi]

<li aria-disabled="true"> is not a valid usecase for aria-disabled.
Basicall

The correct way to disable a button, as @pdanpdan mentioned would be <button disabled>.
And if it's a <a> that is not supposed to be a link, it shouldn't be an <a>. should be render a <span> instead.

Style added in v5.6.10

Examples: https://play.tailwindcss.com/XI7bz8RJ3O

Let me know if you have any questions.