feat: Add Node 16 CI and drop Node 10 by nschonni · Pull Request #3090 · sass/node-sass

nschonni · 2021-04-20T16:43:09Z

Bump to 5.1.0
Add CI builds for 16
Add extension lookup for module 93

nschonni · 2021-04-20T16:44:43Z

Node 16 alpine image isn't out yet, so I expect this to fail for now

nschonni · 2021-04-20T22:34:46Z

@xzyfer looks like there is an internal compiler issue with some of the headers on macOS and Linux. Does this look like a Nan thing, or maybe a compiler version one. I tried bumping to GCC 8 since its' the new minimum, but I don't think it helped

saper · 2021-04-21T06:18:38Z

node 16 alpine containers do not seem to be published there yet
FreeBSD did ~~not~~ merge in node 16 into the ports system commit

saper · 2021-04-21T06:32:11Z

Experimenting with #3091

xzyfer · 2021-04-21T07:42:46Z

Looks like the OSX failure might have a fix https://github.com/microsoft/node-pty/pull/433/files

saper · 2021-04-21T19:26:30Z

#3091 seems to fix this, I wonder if we should be using the same compiler settings for all supported versions...

nschonni · 2021-04-25T17:12:18Z

 {
  "name": "node-sass",
-  "version": "5.0.0",
+  "version": "5.1.0",


@saper @xzyfer should we just bump this to 6 and also drop Node 10 with #3094? Would mean maybe waiting till the end of the week for cutting the release

I'd like to have more research about actual compilers and C++ standards we need. Hope we do not need to use different once for different node versions?

I think one node version out, one node version in is a fair trade, we could do 6.x this way.

I dropped the conditionals entirely here, and the CI seems OK, but that's no guarantee 😄

We should with the same settings as node does. Maybe they are inherited from the node gyp files, we should check this. Long time since I've had look into this...

The c++0x workaround was for the old gcc on MacOS X I think...

I'm fine with bumping to 6 :)

- Bump to 5.1.0 - Add CI builds for 16 - Add extension lookup for module 93

- VS2015 isn't supported anymore - CPP11 flags cause issues on modern tooling

This is the minimum for Node 10 which is the oldest supported version https://github.com/nodejs/node/blob/19f3e1702e9e732462fcf83939b99d3bd0587ed2/BUILDING.md

nschonni · 2021-05-01T19:14:48Z

@xzyfer @saper I added the dropping on Node 10, and bumped it to 6.0.
Do you want to still work on the compiler stuff, or try the trimmed down one and maybe add back if we get reports coming in?

xzyfer · 2021-05-02T03:58:43Z

If we have 16 builds passing I'm happy enough to move forward and deal with any issues as they come up.

…

On Sun, 2 May 2021, 5:15 am Nick Schonning, ***@***.***> wrote: @xzyfer <https://github.com/xzyfer> @saper <https://github.com/saper> I added the dropping on Node 10, and bumped it to 6.0. Do you want to still work on the compiler stuff, or try the trimmed down one and maybe add back if we get reports coming in? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3090 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWCKPUJS6HEPH6KHQE3TLRHLLANCNFSM43IRB52A> .

xzyfer · 2021-05-02T03:59:55Z

Because we haven't changed the binding code I typically copy over the binaries from the previous releases, so I'd only be rebuilding the 16 binaries for release.

…

On Sun, 2 May 2021, 1:58 pm Michael Mifsud, ***@***.***> wrote: If we have 16 builds passing I'm happy enough to move forward and deal with any issues as they come up. On Sun, 2 May 2021, 5:15 am Nick Schonning, ***@***.***> wrote: > @xzyfer <https://github.com/xzyfer> @saper <https://github.com/saper> I > added the dropping on Node 10, and bumped it to 6.0. > Do you want to still work on the compiler stuff, or try the trimmed down > one and maybe add back if we get reports coming in? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#3090 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAENSWCKPUJS6HEPH6KHQE3TLRHLLANCNFSM43IRB52A> > . >

nschonni · 2021-05-02T04:02:02Z

Alpine 16 seems to have some flakey CLI tests, but I think we say that in 15 for awhile too

nschonni · 2021-05-02T04:02:56Z

Feel free to land this whenever you have time to cut the release. I bumped the package.json this time 😄

xzyfer · 2021-05-02T04:07:40Z

My hero!

…

On Sun, 2 May 2021, 2:03 pm Nick Schonning, ***@***.***> wrote: Feel free to land this whenever you have time to cut the release. I bumped the package.json this time 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3090 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWAHHHZZIYDRON7CZP3TLTFH3ANCNFSM43IRB52A> .

xzyfer · 2021-05-08T15:35:46Z

Released v6.0.0 with Node 16 support.

stevecondylios · 2021-05-09T15:33:34Z

Hi there. Thanks for the contributors' support on a tough issue under pressure.

sass/node noobie here. Just wondering, is this problem history now? i.e. is it okay to update to node 16?

From what I read above, I assume it might be okay to go to node 16 now, (although I do see 1 failed check for build 16 (I'm not sure if that affects things): https://github.com/sass/node-sass/runs/2483549702)

Some days back I wrote this quick suggestion for anyone not sure what to do, but if it's now all good to go to node 16, I will update that answer to avoid node 14 and go to 16 now :) Please let mek know if my understanding is correct?

gotjoshua · 2021-11-26T11:38:33Z

@stevecondylios

okay to update to node 16

not on mac osx its not.

asharafshahi · 2022-07-22T01:17:06Z

How about now? If I install the latest will it work with node 16?

This comment has been minimized.

Sign in to view

nschonni changed the title ~~node-16~~ feat: Add Node 16 CI Apr 24, 2021

nschonni commented Apr 25, 2021

View reviewed changes

theoludwig mentioned this pull request Apr 27, 2021

build(deps): bump node from 14.16.1 to 16.0.0 theoludwig/theoludwig#10

Closed

JoshuaVSherman mentioned this pull request Apr 27, 2021

upgrade nodejs versions and replace node-sass with dart-sass, and replace yarn with npm WebJamApps/web-jam-back#549

Closed

2 tasks

Niek mentioned this pull request Apr 28, 2021

[heft] [feature-request] Possibility to (optionally) remove front-end build tooling? microsoft/rushstack#2548

Closed

saper mentioned this pull request Apr 29, 2021

Node 16 support #3077

Closed

4 tasks

XhmikosR mentioned this pull request May 1, 2021

v4-dev backports and updates twbs/bootstrap#33807

Merged

2 tasks

nschonni force-pushed the node-16 branch 2 times, most recently from 7167506 to 7d9b9f6 Compare May 1, 2021 15:09

nschonni added 4 commits May 1, 2021 13:03

chore: Add Node 16 support

83b0b9c

- Bump to 5.1.0 - Add CI builds for 16 - Add extension lookup for module 93

fix: Remove old compiler gyp settings

ce9b1d6

- VS2015 isn't supported anymore - CPP11 flags cause issues on modern tooling

fix: Bump OSX minimum to 10.11

9927ba2

This is the minimum for Node 10 which is the oldest supported version https://github.com/nodejs/node/blob/19f3e1702e9e732462fcf83939b99d3bd0587ed2/BUILDING.md

chore: Drop Node 10 support

432310f

nschonni force-pushed the node-16 branch from 0bb3062 to 432310f Compare May 1, 2021 17:05

nschonni changed the title ~~feat: Add Node 16 CI~~ feat: Add Node 16 CI and drop Node 10 May 1, 2021

xzyfer merged commit 886319b into sass:master May 8, 2021

nschonni deleted the node-16 branch May 8, 2021 14:59

knadh mentioned this pull request May 21, 2021

Can't build under nodejs 16 knadh/listmonk#339

Closed

vashirov mentioned this pull request Jul 26, 2021

Version 2.0.7 doesn't compile with Node.js 16 389ds/389-ds-base#4846

Closed

nanu-c mentioned this pull request Feb 10, 2022

[enhancement] support for node >14 elegantthemes/create-divi-extension#541

Open

querkmachine mentioned this pull request Mar 24, 2022

Migrate GOV.UK Frontend build pipeline to use Dart Sass alphagov/govuk-frontend#2239

Closed

1 task

evwilkin mentioned this pull request Apr 25, 2022

Bug - yarn install fails if running node v16 patternfly/patternfly-org#2938

Closed

Uh oh!

Conversation

nschonni commented Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nschonni commented Apr 20, 2021

Uh oh!

This comment has been minimized.

nschonni commented Apr 20, 2021

Uh oh!

saper commented Apr 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saper commented Apr 21, 2021

Uh oh!

xzyfer commented Apr 21, 2021

Uh oh!

saper commented Apr 21, 2021

Uh oh!

nschonni Apr 25, 2021

Choose a reason for hiding this comment

Uh oh!

saper Apr 25, 2021

Choose a reason for hiding this comment

Uh oh!

nschonni Apr 25, 2021

Choose a reason for hiding this comment

Uh oh!

saper Apr 25, 2021

Choose a reason for hiding this comment

Uh oh!

xzyfer Apr 26, 2021

Choose a reason for hiding this comment

Uh oh!

nschonni commented May 1, 2021

Uh oh!

xzyfer commented May 2, 2021 via email

Uh oh!

xzyfer commented May 2, 2021 via email

Uh oh!

nschonni commented May 2, 2021

Uh oh!

nschonni commented May 2, 2021

Uh oh!

xzyfer commented May 2, 2021 via email

Uh oh!

xzyfer commented May 8, 2021

Uh oh!

stevecondylios commented May 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gotjoshua commented Nov 26, 2021

Uh oh!

asharafshahi commented Jul 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nschonni commented Apr 20, 2021 •

edited

Loading

saper commented Apr 21, 2021 •

edited

Loading

stevecondylios commented May 9, 2021 •

edited

Loading