Skip to content

Implement DeepHashAccessor for accessing seam resources' nested hashes#62

Merged
andrii-balitskyi merged 7 commits into
mainfrom
deep-hash-accessor
Jul 26, 2024
Merged

Implement DeepHashAccessor for accessing seam resources' nested hashes#62
andrii-balitskyi merged 7 commits into
mainfrom
deep-hash-accessor

Conversation

@andrii-balitskyi

@andrii-balitskyi andrii-balitskyi commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

DeepHashAccessor enhances our SDK by providing intuitive dot notation access to nested data structures, automatically handling arbitrary depths of hashes and arrays.

  • Add DeepHashAccessor and use it for accessing nested hashes in BaseResource
  • Add tests

Comment thread lib/seam/base_resource.rb Outdated
@@ -1,5 +1,7 @@
# frozen_string_literal: true

require_relative "utils/deep_hash_accessor"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
require_relative "utils/deep_hash_accessor"
require_relative "./deep_hash_accessor"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move lib/seam/utils/action_attempt_utils.rb out of utils as well?

Comment thread spec/utils/deep_hash_accessor_spec.rb
@andrii-balitskyi
andrii-balitskyi merged commit f8b006a into main Jul 26, 2024
@andrii-balitskyi
andrii-balitskyi deleted the deep-hash-accessor branch July 26, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants