You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like this is still missing a refactor for SeamAuth and SeamOptions?
@razor-x Yea, how the refactor should look like? Should those be also part of Http module?
For ex., SeamAuth -> Seam::Http::InvalidTokenError and Seam::Http.get_auth_headers or Seam::Http::Auth::InvalidTokenError and Seam::Http::Auth.get_auth_headers.
And SeamOptions -> Seam::Http::InvalidOptionsError and Seam::Http.parse_options?
Moving the module into Seam::Http::Auth::InvalidTokenError should be ok. This is all internal, it just didn't make sense before to have a top level SeamAuth module. We can do Seam::Http::Options as well.
Alternatively, Seam::Http::Options and Seam::Http::Auth are classes and Seam::Http::InvalidTokenError and Seam::Http::InvalidOptionsError are thrown by the class. Either approach is fine since these are all internal modules / classes / errors. The user is not meant to handle them in their code like they would the public errors like ActionAttemptFailedError etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrt #71 and #115