Skip to content

Install setuptools on macos workflows - #168

Closed
thegecko wants to merge 2 commits into
serialport:mainfrom
thegecko:fix-macos
Closed

Install setuptools on macos workflows#168
thegecko wants to merge 2 commits into
serialport:mainfrom
thegecko:fix-macos

Conversation

@thegecko

Copy link
Copy Markdown
Contributor

Macos workflows are currently broken because the hosts no longer have some key tools for some reason.

This PR fixes the build and test macos flows

@thegecko

thegecko commented Mar 2, 2024

Copy link
Copy Markdown
Contributor Author

Anything needed to chaperone this through?

@boneskull

boneskull commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

I just ran into this. distutils was removed in Python v3.12

@thegecko

Copy link
Copy Markdown
Contributor Author

@reconbot can we expedite this?

@thegecko

Copy link
Copy Markdown
Contributor Author

bump

@Julusian

Julusian commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

In one place 'macos-11' is used, in another 'macos-latest'.
Does this mean it will break when updating/changing the macos image? Perhaps the check should be done as runner.os == 'macOS' so that it doesn't care what image is used?

@thegecko

thegecko commented Jul 4, 2024

Copy link
Copy Markdown
Contributor Author

In one place 'macos-11' is used, in another 'macos-latest'.

Yeah, I don't know why this is. I'll try to converge on one and see if it still builds....

@Julusian

Julusian commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

In one place 'macos-11' is used, in another 'macos-latest'.

Yeah, I don't know why this is. I'll try to converge on one and see if it still builds....

Part of why I asked this is because the macos-11 image is deprecated and being phased out https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories so that will need changing to macos-12 or something soon, which will also need updating on this check

@reconbot

Copy link
Copy Markdown
Member

I've updated everything to macos-latest which is os14 today. If something like this happens again we can open an issue on the runner images repo and they'll fix it.

@reconbot reconbot closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants