Version 1.11.0#300
Merged
Merged
Conversation
jdm
approved these changes
Jun 17, 2023
Collaborator
Author
Manishearth
approved these changes
Jun 18, 2023
Manishearth
left a comment
Manishearth
left a comment
Member
There was a problem hiding this comment.
r=me for the version bump, haven't looked too closely at the other changes
|
Note that DrainFilter in std has been replaced with ExtractIf which doesn't keep draining on drop. |
Collaborator
Author
Thanks for the heads-up. We can add this new API behind a separate feature if someone has time to implement it, and we can drop the old API in version 2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.