Adding a nfs2 hardcoded entry in Trillian's test_data.py in order to …#18
Conversation
…pass newly introduced test in apache/cloudstack#1961
|
this path is not valid. - we use paths which include the environment name so that they are unique |
|
Thanks @PaulAngus, that makes sense. I guess I'll need to add task to create and delete the directory in the cloudstack-nfsshares/tasks/main.yml ? |
|
@PaulAngus can you look at this and comment if you're happy with this change so we could merge it or review it. There's a newly added test in the smoketests which is failing because of missing this. |
|
tests are passing as well: |
|
it makes no functional difference, but you can make it neater by doing:
|
|
I've added the requested changes, deployed an environment and tests are looking good. Should we proceed with merging this now? |
|
Have updated code to:
|
Moved hardcoded folder names to nested group vars.
|
Thanks for the change @DagSonsteboSB I've tested it and it works as expected now, it's skipping pool creation when it has to. Tests look good as well: |
|
LGTM: root@SBLabNestedNFS ref-trl-104-k-cs410-bstoyanov]# tree |

…pass newly introduced test in apache/cloudstack#1961