Block card input while paused on Android/Kivy#582
Closed
bwrightkc wants to merge 1 commit into
Closed
Conversation
Pause froze the elapsed-time counter but never stopped touch input, so cards could still be dragged and moves counted while paused, letting a run finish with a 0.00 time. LImageItem now checks game.pause before handling touch down/up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pausing on Android didn't stop the game — cards could still be dragged, so moves kept counting while the timer stayed frozen (could finish with 0.00 time).
The pause overlay in Kivy is just an image on top; it never blocked touches. Cards now check
game.pauseand ignore touches while paused, matching desktop.Resubmitting this separately, some comment cleanup I did got merged with this and I wanted to correct it.