Window Position Recall#585
Open
bwrightkc wants to merge 3 commits into
Open
Conversation
Popups were positioned relative to (max(parent_x, 0), max(parent_y, 0)), and then clamped again to the primary screen's width/height, so a root window on a monitor left of/above the primary (negative coordinates) got its dialogs placed near the primary monitor's corner instead of next to the actual window.
let's try this instead in case it ends up outside of screen
Collaborator
|
Noted - I can run tests on Windows 11 and Debian later. Once I get my second monitor set up again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remembers where you left the app window (position, size, monitor) and reopens it there next time — previously it always reset to a default spot. Also fixes popup dialogs (like confirmation prompts and the cardset picker) so they show up next to the actual window instead of jumping back toward the primary monitor when the app is on a second screen. Had to change a few lines in tkutil to ensure that it would still work even if the secondary monitor is positioned to the left (creates a -x situation).
Needs more testing - tested on macOS 27 dev beta and Debian 11 Bullseye. Requesting a few folks give this a try and see how it performs - I already found one issue with it, hence the most recent commit.
Implements #560