Intuitive Menu Navigation for Mobile (Add "Back" Button) + Buildozer portability#589
Merged
Conversation
… be displayed at a time
Contributor
Author
Collaborator
|
A good start, but there are a couple bugs I found:
|
Contributor
Author
Agh! I didn't see Also adding back button to games menu, and going to make it a translatable string as well. |
Collaborator
|
Seems to be working good now. Are you still making tweaks, or am I good to merge? |
Contributor
Author
|
Good to merge |
Collaborator
|
Perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

On the mobile/Kivy UI, opening a menu, then opening a submenu, then tapping the menu button again would stack a second menu panel side-by-side with the first instead of replacing it.
The fix: only one navigational panel (main menu, a submenu, the game picker, help, or about) is ever shown at a time. Opening a new one now automatically closes whatever panel was already open, so navigation always feels like moving to a new screen rather than piling windows up. Confirmation dialogs/notes are unaffected and still will appear next to the menu.
Adds feature requested in #551
Also added a "< Back" entry at the top of every submenu, so you can jump straight back to the main menu without needing to close the submenu and tap the hamburger icon again.
Separately, fixed two small portability bugs in the buildozer/ build scripts that broke Android builds on macOS. Mainly
sed -idoesn't function quite the same on macOS.Requesting people to test this prior to potential merge.