Feature/prd 1102 Remove routing bridge between MapView and native SDK - #683
Open
adrian-situm wants to merge 7 commits into
Open
Feature/prd 1102 Remove routing bridge between MapView and native SDK#683adrian-situm wants to merge 7 commits into
adrian-situm wants to merge 7 commits into
Conversation
adrian-situm
commented
Jul 28, 2026
| Logger.info("Navigation interceptor: ${navigationRequest.toMap()}"); | ||
| // navigationRequest.distanceToGoalThreshold = 10.0; | ||
| // ... | ||
| }); |
Author
There was a problem hiding this comment.
La lógica de los interceptores de navegación y rutas fue removida y las funciones deprecadas. Esta linea ya no hacía nada.
R-lagoman
reviewed
Jul 31, 2026
| @Deprecated('The routing bridge between the MapView and the native SDK ' | ||
| 'has been removed. This handler is kept for backward compatibility ' | ||
| 'and has no effect.') | ||
| class DirectionsMessageHandler implements MessageHandler { |
Contributor
There was a problem hiding this comment.
Todos os "message handler" son de uso interno, non público.
Esto deberías poder eliminalo. Creo que o feito de que sexa pública esta clase é un fallo pola nosa parte (non ten sentido o seu uso por parte de integradores), non creo que teñamos que deprecala.
|
|
||
| @Deprecated('The legacy routing bridge no longer uses this method. ' | ||
| 'It is kept for backward compatibility and has no effect.') | ||
| void populateDirectionsRequest( |
Contributor
There was a problem hiding this comment.
Igual, esto non ten uso desde fóra.
| @Deprecated('The navigation bridge between the MapView and the native SDK ' | ||
| 'has been removed. This handler is kept for backward compatibility ' | ||
| 'and has no effect.') | ||
| class NavigationMessageHandler implements MessageHandler { |
| @Deprecated('The navigation bridge between the MapView and the native SDK ' | ||
| 'has been removed. This handler is kept for backward compatibility ' | ||
| 'and has no effect.') | ||
| class NavigationStopMessageHandler implements MessageHandler { |
| const WV_MESSAGE_AR_REQUESTED = "augmented_reality.requested"; | ||
| const WV_MESSAGE_CARTOGRAPHY_POI_DESELECTED = "cartography.poi_deselected"; | ||
| const WV_MESSAGE_CARTOGRAPHY_POI_SELECTED = "cartography.poi_selected"; | ||
| @Deprecated('The routing bridge between the MapView and the native SDK has ' |
Contributor
There was a problem hiding this comment.
Máis do mismo, si alguén está usando estas constantes é porque está metendo os morros onde non lle chaman. Podemos borralas, son totalmente internas e non forman parte da API pública (polo menos non conscientemente).
fsvilas
approved these changes
Aug 4, 2026
R-lagoman
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.