Skip to content

Completing the implementation of colocated sites. - #127

Merged
ted-ross merged 8 commits into
skupperproject:mainfrom
ted-ross:tross-colo
Jun 18, 2026
Merged

Completing the implementation of colocated sites.#127
ted-ross merged 8 commits into
skupperproject:mainfrom
ted-ross:tross-colo

Conversation

@ted-ross

Copy link
Copy Markdown
Member

No description provided.

Comment thread components/management-controller/src/api-admin.js
@ted-ross
ted-ross marked this pull request as ready for review June 15, 2026 17:32
@ted-ross
ted-ross requested review from JPadovano1483 and fgiorgetti and removed request for fgiorgetti June 16, 2026 16:12
Comment thread components/management-controller/src/sync-management.js
Comment thread components/management-controller/src/colo-sync.js
Comment thread components/management-controller/src/colo-sync.js Outdated
Comment thread components/management-controller/src/backbone-links.js Outdated
Comment thread components/management-controller/src/backbone-links.js Outdated
Comment thread components/management-controller/src/colo-sync.js Outdated
Comment thread components/management-controller/src/colo-sync.js Outdated
Comment thread components/management-controller/src/colo-sync.js Outdated
Comment thread components/management-controller/src/colo-sync.js Outdated
Comment thread components/management-controller/src/colo-sync.js
@JPadovano1483

Copy link
Copy Markdown
Contributor

@ted-ross @fgiorgetti During the initial deployment of the colocated site, I get logs showing an attempt to create the vms-colo-manage secret twice, failing on the second attempt since it already exists. Have either of you run into this?

@fgiorgetti

Copy link
Copy Markdown
Member

@ted-ross @fgiorgetti During the initial deployment of the colocated site, I get logs showing an attempt to create the vms-colo-manage secret twice, failing on the second attempt since it already exists. Have either of you run into this?

@JPadovano1483 I am not seeing it.
Did you update your ClusterRole adding permission to manage listeners?
I remember that without it, I was seeing some 403 errors during the attempt to create the Listener resource.
But other than that, I am not seeing errors on mgmg controller and on site-ctrl logs.

@JPadovano1483

Copy link
Copy Markdown
Contributor

@ted-ross @fgiorgetti During the initial deployment of the colocated site, I get logs showing an attempt to create the vms-colo-manage secret twice, failing on the second attempt since it already exists. Have either of you run into this?

@JPadovano1483 I am not seeing it. Did you update your ClusterRole adding permission to manage listeners? I remember that without it, I was seeing some 403 errors during the attempt to create the Listener resource. But other than that, I am not seeing errors on mgmg controller and on site-ctrl logs.

Yes the clusterrole is updated. Hmm ok, just me then. Haha I'll keep digging then and see if I can find whats going on for me.

@JPadovano1483

Copy link
Copy Markdown
Contributor

After some more testing, I am getting a mixed bag of results. Sometimes everything deploys without any duplication errors. Other times, it tries to recreate almost all the resources. I think this is because there are several paths that call the "visitNamespace" function, which is causing a race condition.

@ted-ross

Copy link
Copy Markdown
Member Author

After some more testing, I am getting a mixed bag of results. Sometimes everything deploys without any duplication errors. Other times, it tries to recreate almost all the resources. I think this is because there are several paths that call the "visitNamespace" function, which is causing a race condition.

I think this is right. If there are multiple instances of visitNamespace running concurrently, we would probably see what James is seeing.

Comment thread components/management-controller/src/colo-sync.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants