Skip to content

apply linting rules - #183

Open
JPadovano1483 wants to merge 3 commits into
skupperproject:mainfrom
JPadovano1483:james-apply-linting
Open

apply linting rules#183
JPadovano1483 wants to merge 3 commits into
skupperproject:mainfrom
JPadovano1483:james-apply-linting

Conversation

@JPadovano1483

@JPadovano1483 JPadovano1483 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Fixed many linting errors and warnings, freeing up committing with the pre-commit hook introduced in #175

Fixes include:

  • converting var to let/const
  • converting let to const when variable is never reassigned
  • removal of unnecessary double negations
  • removal of some unused imports, variables, and functions
  • converted some long logical AND chains to use optional chaining for readability
  • rewrote WatchCertManager function to fix the "async promise executor" error.
  • fixed incorrect variable in AccessPointCR function in resource-templates.js (acess.kind -> data.kind)

NOTE:

  • I opted to prefix unused parameters and a few variables with '_' to ignore the linting warning for now as I wanted to avoid introducing breaking changes or changing function calls to much. A second pass should be performed to specifically address these variables and remove where appropriate.

stacked on #175 - ahead by 1 commit, so only the last commit here needs to be review for this PR
fixes #171, part of #172

@JPadovano1483 JPadovano1483 changed the title James apply linting apply linting rules Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

convert var to let and const

2 participants