Increase minimum CMake version - #328
Closed
jmigual wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
@darrachequesne could you take a look at this? |
Collaborator
Author
|
Also, according to modern cmake (https://hsf-training.github.io/hsf-training-cmake-webpage/07-commonproblems/index.html) the minimum recommended CMake version is 3.4 even for very old projects. |
darrachequesne
pushed a commit
that referenced
this pull request
Nov 23, 2021
Member
studiofuga
pushed a commit
to studiofuga/socket.io-client-cpp
that referenced
this pull request
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #327